fix: use filepath to construct mcp test write path (#19808)

code-asher · web-flow · commit c31768dfe79b · 2025-09-15T09:00:30.000-08:00
Hopefully fixes coder/internal#993 ``` file path must be absolute: "/test/some/path" ``` Not sure if this is the right fix though, since I am not sure how this only flakes rather than always failing. It looks like starting with `/` should not be considered absolute in Windows, but then how did it ever pass at all?
diff --git a/codersdk/toolsdk/toolsdk_test.go b/codersdk/toolsdk/toolsdk_test.go
@@ -615,14 +615,17 @@ func TestTools(t *testing.T) {
 		tb, err := toolsdk.NewDeps(client)
 		require.NoError(t, err)
 
+		tmpdir := os.TempDir()
+		filePath := filepath.Join(tmpdir, "write")
+
 		_, err = testTool(t, toolsdk.WorkspaceWriteFile, tb, toolsdk.WorkspaceWriteFileArgs{
 			Workspace: workspace.Name,
-			Path:      "/test/some/path",
+			Path:      filePath,
 			Content:   []byte("content"),
 		})
 		require.NoError(t, err)
 
-		b, err := afero.ReadFile(fs, "/test/some/path")
+		b, err := afero.ReadFile(fs, filePath)
 		require.NoError(t, err)
 		require.Equal(t, []byte("content"), b)
 	})
