Fix unit tests names

Emyrk · Emyrk · commit c90271590f8d · 2023-02-07T16:21:47.000-06:00
diff --git a/coderd/authzquery/methods_test.go b/coderd/authzquery/methods_test.go
@@ -136,8 +136,8 @@ func (s *MethodTestSuite) Subtest(testCaseF func(db database.Store, check *Metho
 		if len(testCase.Assertions) > 0 {
 			// Only run these tests if we know the underlying call makes
 			// rbac assertions.
-			s.TestNotAuthorized(ctx, fakeAuthorizer, callMethod)
-			s.TestNoActor(callMethod)
+			s.NotAuthorizedErrorTest(ctx, fakeAuthorizer, callMethod)
+			s.NoActorErrorTest(callMethod)
 		}
 
 		// Always run
@@ -180,17 +180,17 @@ func (s *MethodTestSuite) Subtest(testCaseF func(db database.Store, check *Metho
 	}
 }
 
-func (s *MethodTestSuite) TestNoActor(callMethod func(ctx context.Context) ([]reflect.Value, error)) {
+func (s *MethodTestSuite) NoActorErrorTest(callMethod func(ctx context.Context) ([]reflect.Value, error)) {
 	s.Run("NoActor", func() {
 		// Call without any actor
 		_, err := callMethod(context.Background())
 		s.ErrorIs(err, authzquery.NoActorError, "method should return NoActorError error when no actor is provided")
 	})
 }
 
-// TestNotAuthorized runs the given method with an authorizer that will fail authz.
+// NotAuthorizedErrorTest runs the given method with an authorizer that will fail authz.
 // Asserts that the error returned is a NotAuthorizedError.
-func (s *MethodTestSuite) TestNotAuthorized(ctx context.Context, az *coderdtest.FakeAuthorizer, callMethod func(ctx context.Context) ([]reflect.Value, error)) {
+func (s *MethodTestSuite) NotAuthorizedErrorTest(ctx context.Context, az *coderdtest.FakeAuthorizer, callMethod func(ctx context.Context) ([]reflect.Value, error)) {
 	s.Run("NotAuthorized", func() {
 		az.AlwaysReturn = xerrors.New("Always fail authz")
 
@@ -302,8 +302,8 @@ MethodLoop:
 	if len(testCase.Assertions) > 0 {
 		// Only run these tests if we know the underlying call makes
 		// rbac assertions.
-		s.TestNotAuthorized(ctx, fakeAuthorizer, callMethod)
-		s.TestNoActor(callMethod)
+		s.NotAuthorizedErrorTest(ctx, fakeAuthorizer, callMethod)
+		s.NoActorErrorTest(callMethod)
 	}
 
 	// Always run
diff --git a/coderd/authzquery/workspace.go b/coderd/authzquery/workspace.go
@@ -74,6 +74,9 @@ func (q *AuthzQuerier) GetWorkspaceAgentByInstanceID(ctx context.Context, authIn
 // GetWorkspaceAgentsByResourceIDs is an all or nothing call. If the user cannot read
 // a single agent, the entire call will fail.
 func (q *AuthzQuerier) GetWorkspaceAgentsByResourceIDs(ctx context.Context, ids []uuid.UUID) ([]database.WorkspaceAgent, error) {
+	if _, ok := ActorFromContext(ctx); !ok {
+		return nil, NoActorError
+	}
 	// TODO: Make this more efficient. This is annoying because all these resources should be owned by the same workspace.
 	// So the authz check should just be 1 check, but we cannot do that easily here. We should see if all callers can
 	// instead do something like GetWorkspaceAgentsByWorkspaceID.
