check for types

johnstcn · johnstcn · commit ce68fe2e3883 · 2025-01-03T12:11:11.000Z
diff --git a/provisioner/terraform/tfparse/tfparse_test.go b/provisioner/terraform/tfparse/tfparse_test.go
@@ -446,6 +446,99 @@ func Test_WorkspaceTagDefaultsFromFile(t *testing.T) {
 			expectTags:  nil,
 			expectError: `Function calls not allowed; Functions may not be called here.`,
 		},
+		{
+			name: "supported types",
+			files: map[string]string{
+				"main.tf": `
+					variable "stringvar" {
+						type    = string
+						default = "a"
+					}
+					variable "numvar" {
+						type    = number
+						default = 1
+					}
+					variable "boolvar" {
+						type    = bool
+						default = true
+					}
+					data "coder_parameter" "stringparam" {
+						name    = "stringparam"
+						type    = "string"
+						default = "a"
+					}
+					data "coder_parameter" "numparam" {
+						name    = "numparam"
+						type    = "number"
+						default = 1
+					}
+					data "coder_parameter" "boolparam" {
+						name    = "boolparam"
+						type    = "bool"
+						default = true
+					}
+					data "coder_parameter" "listparam" {
+						name    = "listparam"
+						type    = "list(string)"
+						default = "[\"a\", \"b\"]"
+					}
+					data "coder_workspace_tags" "tags" {
+						tags = {
+							"stringvar"   = var.stringvar
+							"numvar"      = var.numvar
+							"boolvar"     = var.boolvar
+							"stringparam" = data.coder_parameter.stringparam.value
+							"numparam"    = data.coder_parameter.numparam.value
+							"boolparam"   = data.coder_parameter.boolparam.value
+							"listparam"   = data.coder_parameter.listparam.value
+						}
+					}`,
+			},
+			expectTags: map[string]string{
+				"stringvar":   "a",
+				"numvar":      "1",
+				"boolvar":     "true",
+				"stringparam": "a",
+				"numparam":    "1",
+				"boolparam":   "true",
+				"listparam":   `["a", "b"]`,
+			},
+			expectError: ``,
+		},
+		{
+			name: "unsupported list variable",
+			files: map[string]string{
+				"main.tf": `
+					variable "listvar" {
+						type    = list(string)
+						default = ["a"]
+					}
+					data "coder_workspace_tags" "tags" {
+						tags = {
+							listvar = var.listvar
+						}
+					}`,
+			},
+			expectTags:  nil,
+			expectError: `can't convert variable default value to string: unsupported type []interface {}`,
+		},
+		{
+			name: "unsupported map variable",
+			files: map[string]string{
+				"main.tf": `
+					variable "mapvar" {
+						type    = map(string)
+						default = {"a": "b"}
+					}
+					data "coder_workspace_tags" "tags" {
+						tags = {
+							mapvar = var.mapvar
+						}
+					}`,
+			},
+			expectTags:  nil,
+			expectError: `can't convert variable default value to string: unsupported type map[string]interface {}`,
+		},
 	} {
 		tc := tc
 		t.Run(tc.name+"/tar", func(t *testing.T) {
