fix: log correct error variable in createTailnet

aaronlehmann · aaronlehmann · commit cf2cf0d479ba · 2025-04-07T16:07:35.000Z
After noticing #17265, I asked Claude Code if it could find similar bugs. It identified this one, which appears to be a valid bug.
diff --git a/agent/agent.go b/agent/agent.go
@@ -1408,7 +1408,7 @@ func (a *agent) createTailnet(
 		if rPTYServeErr != nil &&
 			a.gracefulCtx.Err() == nil &&
 			!strings.Contains(rPTYServeErr.Error(), "use of closed network connection") {
-			a.logger.Error(ctx, "error serving reconnecting PTY", slog.Error(err))
+			a.logger.Error(ctx, "error serving reconnecting PTY", slog.Error(rPTYServeErr))
 		}
 	}); err != nil {
 		return nil, err

Original file line number	Diff line number	Diff line change
`@@ -1408,7 +1408,7 @@ func (a *agent) createTailnet(`
`1408`	`1408`	`if rPTYServeErr != nil &&`
`1409`	`1409`	`a.gracefulCtx.Err() == nil &&`
`1410`	`1410`	`!strings.Contains(rPTYServeErr.Error(), "use of closed network connection") {`
`1411`		`- a.logger.Error(ctx, "error serving reconnecting PTY", slog.Error(err))`
	`1411`	`+ a.logger.Error(ctx, "error serving reconnecting PTY", slog.Error(rPTYServeErr))`
`1412`	`1412`	`}`
`1413`	`1413`	`}); err != nil {`
`1414`	`1414`	`return nil, err`