chore: implement wildcard style matching for param values

Emyrk · Emyrk · commit d4fb9513ae80 · 2024-03-20T16:19:56.000-05:00
diff --git a/coderd/database/queries.sql.go b/coderd/database/queries.sql.go
diff --git a/coderd/database/queries/workspaces.sql b/coderd/database/queries/workspaces.sql
@@ -222,7 +222,7 @@ WHERE
 				build_params
 			ON
 				LOWER(workspace_build_parameters.name) = build_params.name AND
-				LOWER(workspace_build_parameters.value) = build_params.value AND
+				LOWER(workspace_build_parameters.value) LIKE build_params.value AND
 				workspace_build_parameters.workspace_build_id = latest_build.id
 		)
 		ELSE true
diff --git a/coderd/searchquery/search.go b/coderd/searchquery/search.go
@@ -151,8 +151,19 @@ func Workspaces(query string, page codersdk.Pagination, agentInactiveDisconnectT
 			filter.HasParam = append(filter.HasParam, p.name)
 			continue
 		}
+
+		// In postgres, '%' is the wildcard character for matching. But * is a more commonly
+		// used character.
+		// First escape any '%' characters in the value to treat them as literals.
+		valueMatch := strings.ReplaceAll(*p.value, "%", `\%`)
+		// Then replace wildcards with the '%' character. If someone wants the
+		// literal '*' character... then we will have to implement something.
+		// If we have to implement escaping '*', then we have to implement escaping the
+		// escape character as well, which might actually be used in a value.
+		// Let's avoid the complexity until we need it.
+		valueMatch = strings.ReplaceAll(valueMatch, "*", "%")
 		filter.ParamNames = append(filter.ParamNames, p.name)
-		filter.ParamValues = append(filter.ParamValues, *p.value)
+		filter.ParamValues = append(filter.ParamValues, valueMatch)
 	}
 
 	parser.ErrorExcessParams(values)

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,7 @@ WHERE`
`222`	`222`	`build_params`
`223`	`223`	`ON`
`224`	`224`	`LOWER(workspace_build_parameters.name) = build_params.name AND`
`225`		`- LOWER(workspace_build_parameters.value) = build_params.value AND`
	`225`	`+ LOWER(workspace_build_parameters.value) LIKE build_params.value AND`
`226`	`226`	`workspace_build_parameters.workspace_build_id = latest_build.id`
`227`	`227`	`)`
`228`	`228`	`ELSE true`