fix: remove "something went wrong" text for watching a workspace

kylecarbs · kylecarbs · commit dccc11d4a21e · 2023-03-09T20:33:56.000Z
This text wasn't useful to a customer anyways, because we don't get
an error from EventSource. This can happen if you close your laptop
and open it again, so it's better if we don't display it.
diff --git a/site/src/components/Workspace/Workspace.stories.tsx b/site/src/components/Workspace/Workspace.stories.tsx
@@ -113,16 +113,6 @@ GetBuildsError.args = {
   },
 }
 
-export const GetResourcesError = Template.bind({})
-GetResourcesError.args = {
-  ...Running.args,
-  workspaceErrors: {
-    [WorkspaceErrors.GET_RESOURCES_ERROR]: Mocks.makeMockApiError({
-      message: "There is a problem fetching workspace resources.",
-    }),
-  },
-}
-
 export const CancellationError = Template.bind({})
 CancellationError.args = {
   ...Failed.args,
diff --git a/site/src/components/Workspace/Workspace.tsx b/site/src/components/Workspace/Workspace.tsx
@@ -26,11 +26,9 @@ import { AgentRow } from "components/Resources/AgentRow"
 import { Avatar } from "components/Avatar/Avatar"
 
 export enum WorkspaceErrors {
-  GET_RESOURCES_ERROR = "getResourcesError",
   GET_BUILDS_ERROR = "getBuildsError",
   BUILD_ERROR = "buildError",
   CANCELLATION_ERROR = "cancellationError",
-  WORKSPACE_REFRESH_WARNING = "refreshWorkspaceWarning",
 }
 
 export interface WorkspaceProps {
@@ -111,16 +109,6 @@ export const Workspace: FC<React.PropsWithChildren<WorkspaceProps>> = ({
     />
   )
 
-  const workspaceRefreshWarning = Boolean(
-    workspaceErrors[WorkspaceErrors.WORKSPACE_REFRESH_WARNING],
-  ) && (
-    <AlertBanner
-      severity="warning"
-      text={t("warningsAndErrors.workspaceRefreshWarning")}
-      dismissible
-    />
-  )
-
   let transitionStats: TypesGen.TransitionStats | undefined = undefined
   if (template !== undefined) {
     transitionStats = ActiveTransition(template, workspace)
@@ -187,7 +175,6 @@ export const Workspace: FC<React.PropsWithChildren<WorkspaceProps>> = ({
       >
         {buildError}
         {cancellationError}
-        {workspaceRefreshWarning}
 
         <WorkspaceDeletedBanner
           workspace={workspace}
@@ -207,13 +194,6 @@ export const Workspace: FC<React.PropsWithChildren<WorkspaceProps>> = ({
           />
         )}
 
-        {Boolean(workspaceErrors[WorkspaceErrors.GET_RESOURCES_ERROR]) && (
-          <AlertBanner
-            severity="error"
-            error={workspaceErrors[WorkspaceErrors.GET_RESOURCES_ERROR]}
-          />
-        )}
-
         {typeof resources !== "undefined" && resources.length > 0 && (
           <Resources
             resources={resources}
diff --git a/site/src/pages/WorkspacePage/WorkspaceReadyPage.tsx b/site/src/pages/WorkspacePage/WorkspaceReadyPage.tsx
@@ -46,7 +46,6 @@ export const WorkspaceReadyPage = ({
     workspace,
     template,
     templateParameters,
-    refreshWorkspaceWarning,
     builds,
     getBuildsError,
     buildError,
@@ -119,7 +118,6 @@ export const WorkspaceReadyPage = ({
         hideSSHButton={featureVisibility["browser_only"]}
         hideVSCodeDesktopButton={featureVisibility["browser_only"]}
         workspaceErrors={{
-          [WorkspaceErrors.GET_RESOURCES_ERROR]: refreshWorkspaceWarning,
           [WorkspaceErrors.GET_BUILDS_ERROR]: getBuildsError,
           [WorkspaceErrors.BUILD_ERROR]: buildError,
           [WorkspaceErrors.CANCELLATION_ERROR]: cancellationError,
diff --git a/site/src/xServices/workspace/workspaceXService.ts b/site/src/xServices/workspace/workspaceXService.ts
@@ -58,8 +58,6 @@ export interface WorkspaceContext {
   templateParameters?: TypesGen.TemplateVersionParameter[]
   build?: TypesGen.WorkspaceBuild
   getWorkspaceError?: Error | unknown
-  // these are labeled as warnings because they don't make the page unusable
-  refreshWorkspaceWarning?: Error | unknown
   getTemplateWarning: Error | unknown
   getTemplateParametersWarning: Error | unknown
   // Builds
@@ -278,18 +276,15 @@ export const workspaceMachine = createMachine(
                 },
                 on: {
                   REFRESH_WORKSPACE: {
-                    actions: [
-                      "refreshWorkspace",
-                      "clearRefreshWorkspaceWarning",
-                    ],
+                    actions: ["refreshWorkspace"],
                   },
                   EVENT_SOURCE_ERROR: {
                     target: "error",
                   },
                 },
               },
               error: {
-                entry: "assignRefreshWorkspaceWarning",
+                entry: "logWatchWorkspaceWarning",
                 after: {
                   "2000": {
                     target: "gettingEvents",
@@ -586,12 +581,9 @@ export const workspaceMachine = createMachine(
       refreshWorkspace: assign({
         workspace: (_, event) => event.data,
       }),
-      assignRefreshWorkspaceWarning: assign({
-        refreshWorkspaceWarning: (_, event) => event,
-      }),
-      clearRefreshWorkspaceWarning: assign({
-        refreshWorkspaceWarning: (_) => undefined,
-      }),
+      logWatchWorkspaceWarning: (_, event) => {
+        console.error("Watch workspace error:", event)
+      },
       assignGetTemplateWarning: assign({
         getTemplateWarning: (_, event) => event.data,
       }),
