where my members at yo

johnstcn · johnstcn · commit dce10b57fc40 · 2023-02-03T19:53:48.000Z
diff --git a/coderd/members.go b/coderd/members.go
@@ -55,20 +55,20 @@ func (api *API) putMemberRoles(rw http.ResponseWriter, r *http.Request) {
 
 	// Assigning a role requires the create permission.
 	if len(added) > 0 && !api.Authorize(r, rbac.ActionCreate, rbac.ResourceOrgRoleAssignment.InOrg(organization.ID)) {
-		httpapi.Forbidden(rw)
+		httpapi.ResourceNotFound(rw)
 		return
 	}
 
 	// Removing a role requires the delete permission.
 	if len(removed) > 0 && !api.Authorize(r, rbac.ActionDelete, rbac.ResourceOrgRoleAssignment.InOrg(organization.ID)) {
-		httpapi.Forbidden(rw)
+		httpapi.ResourceNotFound(rw)
 		return
 	}
 
 	// Just treat adding & removing as "assigning" for now.
 	for _, roleName := range append(added, removed...) {
 		if !rbac.CanAssignRole(actorRoles.Actor.Roles, roleName) {
-			httpapi.Forbidden(rw)
+			httpapi.ResourceNotFound(rw)
 			return
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -55,20 +55,20 @@ func (api API) putMemberRoles(rw http.ResponseWriter, r http.Request) {`
`55`	`55`
`56`	`56`	`// Assigning a role requires the create permission.`
`57`	`57`	`if len(added) > 0 && !api.Authorize(r, rbac.ActionCreate, rbac.ResourceOrgRoleAssignment.InOrg(organization.ID)) {`
`58`		`- httpapi.Forbidden(rw)`
	`58`	`+ httpapi.ResourceNotFound(rw)`
`59`	`59`	`return`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`// Removing a role requires the delete permission.`
`63`	`63`	`if len(removed) > 0 && !api.Authorize(r, rbac.ActionDelete, rbac.ResourceOrgRoleAssignment.InOrg(organization.ID)) {`
`64`		`- httpapi.Forbidden(rw)`
	`64`	`+ httpapi.ResourceNotFound(rw)`
`65`	`65`	`return`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`// Just treat adding & removing as "assigning" for now.`
`69`	`69`	`for _, roleName := range append(added, removed...) {`
`70`	`70`	`if !rbac.CanAssignRole(actorRoles.Actor.Roles, roleName) {`
`71`		`- httpapi.Forbidden(rw)`
	`71`	`+ httpapi.ResourceNotFound(rw)`
`72`	`72`	`return`
`73`	`73`	`}`
`74`	`74`	`}`