fix: Use "make build" on deploy (#1261)

kylecarbs · web-flow · commit e4e60256ac7b · 2022-05-02T14:04:45.000-05:00
This was a missed item in #1259.
diff --git a/.github/workflows/coder.yaml b/.github/workflows/coder.yaml
@@ -355,7 +355,7 @@ jobs:
             js-${{ runner.os }}-
 
       - name: Build Release
-        run: make release
+        run: make build
 
       - uses: actions/upload-artifact@v3
         with:
diff --git a/Makefile b/Makefile
@@ -1,9 +1,15 @@
+.DEFAULT_GOAL := build
+
 INSTALL_DIR=$(shell go env GOPATH)/bin
 GOOS=$(shell go env GOOS)
 GOARCH=$(shell go env GOARCH)
 
-# First target is the default for `make`.
-build: dist
+bin: $(shell find -not -path './vendor/*' -type f -name '*.go') go.mod go.sum
+	@echo "== This builds binaries for command-line usage."
+	@echo "== Use \"make build\" to embed the site."
+	goreleaser build --snapshot --rm-dist --single-target
+
+build: dist/artifacts.json
 .PHONY: build
 
 # Runs migrations to output a dump of the database.
@@ -14,9 +20,8 @@ coderd/database/dump.sql: $(wildcard coderd/database/migrations/*.sql)
 coderd/database/querier.go: coderd/database/dump.sql $(wildcard coderd/database/queries/*.sql)
 	coderd/database/generate.sh
 
-# This is called "dist" to target the output directory for binaries.
-dist: site/out $(find -not -path './vendor/*' -type f -name '*.go') go.mod go.sum
-	goreleaser build --snapshot --rm-dist
+dist/artifacts.json: site/out $(shell find -not -path './vendor/*' -type f -name '*.go') go.mod go.sum
+	goreleaser release --snapshot --rm-dist --skip-sign
 
 fmt/prettier:
 	@echo "--- prettier"
@@ -30,6 +35,7 @@ endif
 
 fmt/terraform: $(wildcard *.tf)
 	terraform fmt -recursive
+.PHONY: fmt/terraform
 
 fmt: fmt/prettier fmt/terraform
 .PHONY: fmt
diff --git a/docs/CONTRIBUTING.md b/docs/CONTRIBUTING.md
@@ -9,10 +9,9 @@ Coder requires Go 1.18+, Node 14+, and GNU Make.
 
 Use the following `make` commands and scripts in development:
 
-- `make bin` builds binaries
+- `make build` compiles binaries and release packages
 - `make install` installs binaries to `$GOPATH/bin`
 - `make test`
-- `make release` dry runs a new release
 - `./develop.sh` hot reloads for front-end development
 
 ## Styling
