test(agent): fix channel timeout in TestNewServer_CloseActiveConnections (#17690)

mafredri · web-flow · commit ebad5c3ed02a · 2025-05-06T11:20:28.000Z
This fixes a test issue where we were waiting on a channel indefinitely and the test timed out instead of failing due to earlier error. Updates coder/internal#558
diff --git a/agent/agentssh/agentssh_test.go b/agent/agentssh/agentssh_test.go
@@ -214,7 +214,11 @@ func TestNewServer_CloseActiveConnections(t *testing.T) {
 		}
 
 		for _, ch := range waitConns {
-			<-ch
+			select {
+			case <-ctx.Done():
+				t.Fatal("timeout")
+			case <-ch:
+			}
 		}
 
 		return s, wg.Wait

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,11 @@ func TestNewServer_CloseActiveConnections(t *testing.T) {`
`214`	`214`	`}`
`215`	`215`
`216`	`216`	`for _, ch := range waitConns {`
`217`		`- <-ch`
	`217`	`+ select {`
	`218`	`+ case <-ctx.Done():`
	`219`	`+ t.Fatal("timeout")`
	`220`	`+ case <-ch:`
	`221`	`+ }`
`218`	`222`	`}`
`219`	`223`
`220`	`224`	`return s, wg.Wait`