Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit ebf2f77

Browse files
committed
Fix log cleanup
1 parent 83eb9ca commit ebf2f77

File tree

4 files changed

+14
-6
lines changed

4 files changed

+14
-6
lines changed

coderd/projectversions_test.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,9 @@ func TestProjectVersionLogs(t *testing.T) {
196196
},
197197
}},
198198
})
199-
logs, err := client.ProjectVersionLogsAfter(context.Background(), version.ID, before)
199+
ctx, cancelFunc := context.WithCancel(context.Background())
200+
t.Cleanup(cancelFunc)
201+
logs, err := client.ProjectVersionLogsAfter(ctx, version.ID, before)
200202
require.NoError(t, err)
201203
log := <-logs
202204
require.Equal(t, "example", log.Output)

coderd/provisionerjobs_test.go

+6-2
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,9 @@ func TestProvisionerJobLogs(t *testing.T) {
4747
require.NoError(t, err)
4848
coderdtest.AwaitWorkspaceBuildJob(t, client, build.ID)
4949

50-
logs, err := client.WorkspaceBuildLogsAfter(context.Background(), build.ID, before)
50+
ctx, cancelFunc := context.WithCancel(context.Background())
51+
t.Cleanup(cancelFunc)
52+
logs, err := client.WorkspaceBuildLogsAfter(ctx, build.ID, before)
5153
require.NoError(t, err)
5254
log, ok := <-logs
5355
require.True(t, ok)
@@ -86,7 +88,9 @@ func TestProvisionerJobLogs(t *testing.T) {
8688
Transition: database.WorkspaceTransitionStart,
8789
})
8890
require.NoError(t, err)
89-
logs, err := client.WorkspaceBuildLogsAfter(context.Background(), build.ID, before)
91+
ctx, cancelFunc := context.WithCancel(context.Background())
92+
t.Cleanup(cancelFunc)
93+
logs, err := client.WorkspaceBuildLogsAfter(ctx, build.ID, before)
9094
require.NoError(t, err)
9195
log := <-logs
9296
require.Equal(t, "log-output", log.Output)

coderd/workspacebuilds_test.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,9 @@ func TestWorkspaceBuildLogs(t *testing.T) {
141141
Transition: database.WorkspaceTransitionStart,
142142
})
143143
require.NoError(t, err)
144-
logs, err := client.WorkspaceBuildLogsAfter(context.Background(), build.ID, before)
144+
ctx, cancelFunc := context.WithCancel(context.Background())
145+
t.Cleanup(cancelFunc)
146+
logs, err := client.WorkspaceBuildLogsAfter(ctx, build.ID, before)
145147
require.NoError(t, err)
146148
log := <-logs
147149
require.Equal(t, "example", log.Output)

site/api.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ export namespace Workspace {
108108
}
109109

110110
export const login = async (email: string, password: string): Promise<LoginResponse> => {
111-
const response = await fetch("/api/v2/login", {
111+
const response = await fetch("/api/v2/users/login", {
112112
method: "POST",
113113
headers: {
114114
"Content-Type": "application/json",
@@ -128,7 +128,7 @@ export const login = async (email: string, password: string): Promise<LoginRespo
128128
}
129129

130130
export const logout = async (): Promise<void> => {
131-
const response = await fetch("/api/v2/logout", {
131+
const response = await fetch("/api/v2/users/logout", {
132132
method: "POST",
133133
})
134134

0 commit comments

Comments
 (0)