fix(vpn/tunnel): fix panic when starting tunnel with headers (#16565)

ethanndickson · web-flow · commit edd982e85201 · 2025-02-14T03:11:51.000Z
`http.Header` is a map so it needs to be initialized ..
diff --git a/vpn/tunnel.go b/vpn/tunnel.go
@@ -230,7 +230,7 @@ func (t *Tunnel) start(req *StartRequest) error {
 	if apiToken == "" {
 		return xerrors.New("missing api token")
 	}
-	var header http.Header
+	header := make(http.Header)
 	for _, h := range req.GetHeaders() {
 		header.Add(h.GetName(), h.GetValue())
 	}
diff --git a/vpn/tunnel_internal_test.go b/vpn/tunnel_internal_test.go
@@ -100,6 +100,9 @@ func TestTunnel_StartStop(t *testing.T) {
 					TunnelFileDescriptor: 2,
 					CoderUrl:             "https://coder.example.com",
 					ApiToken:             "fakeToken",
+					Headers: []*StartRequest_Header{
+						{Name: "X-Test-Header", Value: "test"},
+					},
 				},
 			},
 		})

Original file line number	Diff line number	Diff line change
`@@ -230,7 +230,7 @@ func (t Tunnel) start(req StartRequest) error {`
`230`	`230`	`if apiToken == "" {`
`231`	`231`	`return xerrors.New("missing api token")`
`232`	`232`	`}`
`233`		`- var header http.Header`
	`233`	`+ header := make(http.Header)`
`234`	`234`	`for _, h := range req.GetHeaders() {`
`235`	`235`	`header.Add(h.GetName(), h.GetValue())`
`236`	`236`	`}`