Fix race condition for the last node

kylecarbs · kylecarbs · commit f2bd8fb1b790 · 2022-08-24T00:31:04.000Z
diff --git a/tailnet/conn.go b/tailnet/conn.go
@@ -265,8 +265,9 @@ func (c *Conn) SetNodeCallback(callback func(node *Node)) {
 		c.lastMutex.Lock()
 		c.lastPreferredDERP = ni.PreferredDERP
 		c.lastDERPLatency = ni.DERPLatency
+		node := makeNode()
 		c.lastMutex.Unlock()
-		callback(makeNode())
+		callback(node)
 	})
 	c.wireguardEngine.SetStatusCallback(func(s *wgengine.Status, err error) {
 		if err != nil {
@@ -278,8 +279,9 @@ func (c *Conn) SetNodeCallback(callback func(node *Node)) {
 		}
 		c.lastMutex.Lock()
 		c.lastEndpoints = endpoints
+		node := makeNode()
 		c.lastMutex.Unlock()
-		callback(makeNode())
+		callback(node)
 	})
 }
 
