fix(coderd/database): add fk index for workspace_agent_scripts

mafredri · mafredri · commit f33ca15c1d09 · 2024-03-28T12:06:42.000Z
I noticed we were missing this index while looking at query
performances, we were doing sequential scans on the table via the
`GetWorkspaceAgentScriptsByAgentIDs` query, which is relatively fast
whilst the table is small, but at 8.5k calls/hour in our dogfood
instance, it will become problematic eventually.
diff --git a/coderd/database/dump.sql b/coderd/database/dump.sql
diff --git a/coderd/database/migrations/000204_add_workspace_agent_scripts_fk_index.down.sql b/coderd/database/migrations/000204_add_workspace_agent_scripts_fk_index.down.sql
@@ -0,0 +1 @@
+DROP INDEX workspace_agent_scripts_workspace_agent_id_idx;
diff --git a/coderd/database/migrations/000204_add_workspace_agent_scripts_fk_index.up.sql b/coderd/database/migrations/000204_add_workspace_agent_scripts_fk_index.up.sql
@@ -0,0 +1,3 @@
+CREATE INDEX workspace_agent_scripts_workspace_agent_id_idx ON workspace_agent_scripts (workspace_agent_id);
+
+COMMENT ON INDEX workspace_agent_scripts_workspace_agent_id_idx IS 'Foreign key support index for faster lookups';

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+DROP INDEX workspace_agent_scripts_workspace_agent_id_idx;`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+CREATE INDEX workspace_agent_scripts_workspace_agent_id_idx ON workspace_agent_scripts (workspace_agent_id);`
	`2`	`+`
	`3`	`+COMMENT ON INDEX workspace_agent_scripts_workspace_agent_id_idx IS 'Foreign key support index for faster lookups';`