Push functionality up to BasePOM API

bryphe-coder · bryphe-coder · commit fae6b3f7e36e · 2022-03-02T04:39:56.000Z
diff --git a/site/e2e/pom/BasePom.ts b/site/e2e/pom/BasePom.ts
@@ -1,13 +1,17 @@
 import { Page } from "@playwright/test"
 
 export abstract class BasePom {
-  abstract get url(): string
+  protected readonly baseURL: string | undefined
+  protected readonly path: string
+  protected readonly page: Page
 
-  protected page: Page
-  protected baseURL: string | undefined
-
-  constructor(baseURL: string | undefined, page: Page) {
-    this.page = page
+  constructor(baseURL: string | undefined, path: string, page: Page) {
     this.baseURL = baseURL
+    this.path = path
+    this.page = page
+  }
+
+  get url(): string {
+    return this.baseURL + this.path
   }
 }
diff --git a/site/e2e/pom/ProjectsPage.ts b/site/e2e/pom/ProjectsPage.ts
@@ -2,11 +2,7 @@ import { Page } from "@playwright/test"
 import { BasePom } from "./BasePom"
 
 export class ProjectsPage extends BasePom {
-  public get url(): string {
-    return this.baseURL + "/projects"
-  }
-
   constructor(baseURL: string | undefined, page: Page) {
-    super(baseURL, page)
+    super(baseURL, "/projects", page)
   }
 }
diff --git a/site/e2e/pom/SignInPage.ts b/site/e2e/pom/SignInPage.ts
@@ -2,12 +2,8 @@ import { Page } from "@playwright/test"
 import { BasePom } from "./BasePom"
 
 export class SignInPage extends BasePom {
-  public get url(): string {
-    return this.baseURL + "/login"
-  }
-
   constructor(baseURL: string | undefined, page: Page) {
-    super(baseURL, page)
+    super(baseURL, "/login", page)
   }
 
   async submitBuiltInAuthentication(email: string, password: string): Promise<void> {

Original file line number	Diff line number	Diff line change
`@@ -2,11 +2,7 @@ import { Page } from "@playwright/test"`
`2`	`2`	`import { BasePom } from "./BasePom"`
`3`	`3`
`4`	`4`	`export class ProjectsPage extends BasePom {`
`5`		`- public get url(): string {`
`6`		`- return this.baseURL + "/projects"`
`7`		`- }`
`8`		`-`
`9`	`5`	`constructor(baseURL: string \| undefined, page: Page) {`
`10`		`- super(baseURL, page)`
	`6`	`+ super(baseURL, "/projects", page)`
`11`	`7`	`}`
`12`	`8`	`}`