Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: icon for github-enterprise git external auth is a lock #13080

Closed
@michaelbrewer

Description

@michaelbrewer

When configuring github enterprise account to the docs: https://coder.com/docs/v2/latest/admin/external-auth#github-enterprise

CODER_EXTERNAL_AUTH_4_ID="example-github"
CODER_EXTERNAL_AUTH_4_TYPE=github-enterprise
CODER_EXTERNAL_AUTH_4_DISPLAY_NAME="Github - Example"
CODER_EXTERNAL_AUTH_4_CLIENT_ID="Iv1.EXAMPLE"
CODER_EXTERNAL_AUTH_4_CLIENT_SECRET="example"
CODER_EXTERNAL_AUTH_4_VALIDATE_URL="https://github.example.com/api/v3/user"
CODER_EXTERNAL_AUTH_4_AUTH_URL="https://github.example.com/login/oauth/authorize"
CODER_EXTERNAL_AUTH_4_TOKEN_URL="https://github.example.com/login/oauth/access_token"
CODER_EXTERNAL_AUTH_4_REGEX=github\.example.com\.net

The icon is a generic lock

Screenshot 2024-04-25 at 3 20 48 PM

Looks like the docs is not matching with the options

const (
	EnhancedExternalAuthProviderAzureDevops EnhancedExternalAuthProvider = "azure-devops"
	// Authenticate to ADO using an app registration in Entra ID
	EnhancedExternalAuthProviderAzureDevopsEntra EnhancedExternalAuthProvider = "azure-devops-entra"
	EnhancedExternalAuthProviderGitHub           EnhancedExternalAuthProvider = "github"
	EnhancedExternalAuthProviderGitLab           EnhancedExternalAuthProvider = "gitlab"
	// EnhancedExternalAuthProviderBitBucketCloud is the Bitbucket Cloud provider.
	// Not to be confused with the self-hosted 'EnhancedExternalAuthProviderBitBucketServer'
	EnhancedExternalAuthProviderBitBucketCloud  EnhancedExternalAuthProvider = "bitbucket-cloud"
	EnhancedExternalAuthProviderBitBucketServer EnhancedExternalAuthProvider = "bitbucket-server"
	EnhancedExternalAuthProviderSlack           EnhancedExternalAuthProvider = "slack"
	EnhancedExternalAuthProviderJFrog           EnhancedExternalAuthProvider = "jfrog"
	EnhancedExternalAuthProviderGitea           EnhancedExternalAuthProvider = "gitea"
)

Example should be :

CODER_EXTERNAL_AUTH_4_ID="example-github"
CODER_EXTERNAL_AUTH_4_TYPE=github
CODER_EXTERNAL_AUTH_4_DISPLAY_NAME="Github - Example"
CODER_EXTERNAL_AUTH_4_CLIENT_ID="Iv1.EXAMPLE"
CODER_EXTERNAL_AUTH_4_CLIENT_SECRET="example"
CODER_EXTERNAL_AUTH_4_VALIDATE_URL="https://github.example.com/api/v3/user"
CODER_EXTERNAL_AUTH_4_AUTH_URL="https://github.example.com/login/oauth/authorize"
CODER_EXTERNAL_AUTH_4_TOKEN_URL="https://github.example.com/login/oauth/access_token"
CODER_EXTERNAL_AUTH_4_REGEX=github\.example.com\.net

Metadata

Metadata

Assignees

No one assigned

    Labels

    design neededRequest for more beautyenterpriseEnterprise-license / premium functionalitys3Bugs that confuse, annoy, or are purely cosmeticsiteArea: frontend dashboard

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions