Thanks to visit codestin.com
Credit goes to github.com

Skip to content

agent logs don't stream on web when writing from a second log source - 2.13 regression #14257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spikecurtis opened this issue Aug 13, 2024 · 5 comments · Fixed by #14541
Closed
Assignees
Labels
customer-reported Bugs reported by enterprise customers. Only humans may set this. must-do Issues that must be completed by the end of the Sprint. Or else. Only humans may set this. regression Something that used to work but no longer works s2 Broken use cases or features (with a workaround). Only humans may set this. site Area: frontend dashboard

Comments

@spikecurtis
Copy link
Contributor

The Agent is coming up and sending logs to Coderd, and then in addition, you have a second program that is also sending logs to Coderd, using the same Agent token.

The logs the Agent sends (e.g. logs from startup scripts) are appearing in the Web Dashboard, and stream in while the workspace is starting.

The logs the second program sends do not appear initially, but then if you refresh your browser, they appear as well, along side the logs the Agent sends. This happens regardless of whether you use the LogsSender (HTTP PATCH API) or the NewLogsSender (dRPC over websocket API) to send the logs.

Also, on Coder server version 2.12.1, the logs from the second program streamed correctly.

@spikecurtis spikecurtis added s2 Broken use cases or features (with a workaround). Only humans may set this. bug customer-reported Bugs reported by enterprise customers. Only humans may set this. labels Aug 13, 2024
@coder-labeler coder-labeler bot added regression Something that used to work but no longer works s3 Bugs that confuse, annoy, or are purely cosmetic site Area: frontend dashboard labels Aug 13, 2024
@spikecurtis spikecurtis removed the s3 Bugs that confuse, annoy, or are purely cosmetic label Aug 13, 2024
@MoeRT09
Copy link

MoeRT09 commented Aug 15, 2024

This is also noticeable, when using Envbox. The image download progress only appears after refreshing the browser window. As soon as Envbox bootstrapped the workspace, the logs from startup scripts come in as normal again.

@bpmct
Copy link
Member

bpmct commented Aug 29, 2024

This happens to me with envbuilder as well!

@bpmct bpmct added the must-do Issues that must be completed by the end of the Sprint. Or else. Only humans may set this. label Aug 29, 2024
@bpmct
Copy link
Member

bpmct commented Aug 29, 2024

@mtojek @BrunoQuaresma can you investigate for 🥥 this sprint?

@mtojek
Copy link
Member

mtojek commented Aug 29, 2024

@BrunoQuaresma I assigned this one to you at first to reproduce it on the frontend side first and verify if it is a site problem.

@aaronlehmann
Copy link
Contributor

It looks like this regressed in 2.15.1. Looking at the code, the fix does not seem to be included in that release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Bugs reported by enterprise customers. Only humans may set this. must-do Issues that must be completed by the end of the Sprint. Or else. Only humans may set this. regression Something that used to work but no longer works s2 Broken use cases or features (with a workaround). Only humans may set this. site Area: frontend dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants