Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove theme overrides #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
greyscaled opened this issue May 14, 2022 · 1 comment
Closed

Remove theme overrides #1449

greyscaled opened this issue May 14, 2022 · 1 comment
Assignees
Labels
site Area: frontend dashboard
Milestone

Comments

@greyscaled
Copy link
Contributor

greyscaled commented May 14, 2022

Overview

The global overrides to MUI in our theme is a pattern we want to drop and a piece of tech debt.

The file lives here: https://github.com/coder/coder/blob/main/site/src/theme/overrides.ts and we'd like to completely remove it. The justification for removing it is that it is a complicated set of tech debt that distances us from MUI and creates additional overhead in styling and updating MUI w.r.t understanding breakages.

An experiment to see what would break was pushed in #1444. See the chromatic build from #1444 here: https://www.chromatic.com/build?appId=624de63c6aacee003aa84340&number=1529

It is likely that this effort will need to become an epic of tasks such that we can incrementally remove overrides.

This effort relates to (and this should considered to be blocked by) #803 (especially #699)

Acceptance Criteria

  1. Strategize and decompose into series of tasks for removing overrides
  2. On completion, overrides.ts is deleted
@greyscaled greyscaled added bug πŸ› site Area: frontend dashboard and removed bug πŸ› labels May 14, 2022
@greyscaled greyscaled changed the title Refactor: Remove theme overrides Remove theme overrides May 14, 2022
@Kira-Pilot Kira-Pilot assigned Kira-Pilot and unassigned Kira-Pilot May 16, 2022
@misskniss misskniss added this to the Community MVP milestone May 17, 2022
@misskniss
Copy link

fixed by #1450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site Area: frontend dashboard
Projects
None yet
Development

No branches or pull requests

4 participants