Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Doc Issues Prometheus Integration #15385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
francisco-mata opened this issue Nov 5, 2024 · 1 comment · Fixed by #16918
Closed

Doc Issues Prometheus Integration #15385

francisco-mata opened this issue Nov 5, 2024 · 1 comment · Fixed by #16918
Labels
docs Area: coder.com/docs docs-ready Ready to be worked on for docs, details are clear

Comments

@francisco-mata
Copy link

Hi Coders, found some doc issues on this page:

https://coder.com/docs/admin/integrations/prometheus

First error on the Service Monitor the port name is not matching based on the Service above.

Service Name: - name: prom-http
Service Monitor Port Name: - port: prometheus-http

Second suggested changed. For some reason our target was not appearing on our prometheus targets, we had to add a namespaceSelector key on the Service Monitor to successfully appear

apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  annotations: []
  labels: {}
  name: coder-service-monitor
  namespace: coder
spec:
  endpoints:
  - interval: 10s
    port: prom-http
    scrapeTimeout: 10s
  namespaceSelector:
    matchNames:
    - coder
  selector:
    matchLabels:
      app.kubernetes.io/name: coder

Regards,
Mata
@coder-labeler coder-labeler bot added the docs Area: coder.com/docs label Nov 5, 2024
@EdwardAngert EdwardAngert added the docs-ready Ready to be worked on for docs, details are clear label Dec 5, 2024
@EdwardAngert
Copy link
Contributor

thanks @francisco-mata!

@EdwardAngert EdwardAngert mentioned this issue Mar 13, 2025
Merged
SasSwart pushed a commit that referenced this issue Mar 17, 2025
@EdwardAngert @SasSwart
docs: use consistent examples in prometheus doc and add namespaceSele…
6ac8bd6 
…ctor spec (#16918)

closes: #15385 

- use consistent `prom-http` port (@johnstcn looks like this was
changed/added in #12214 - do we prefer `prom-http` over
`prometheus-http` or is it more important that they align?)
- add `namespaceSelector:` per @francisco-mata (thanks! - sorry it took
so long to get this in)

   from issue:

> For some reason our target was not appearing on our prometheus
targets, we had to add a namespaceSelector key on the Service Monitor to
successfully appear

Co-authored-by: EdwardAngert <[email protected]>
EdwardAngert added a commit that referenced this issue Mar 18, 2025
@EdwardAngert
docs: use consistent examples in prometheus doc and add namespaceSele…
47628c9 
…ctor spec (#16918)

closes: #15385 

- use consistent `prom-http` port (@johnstcn looks like this was
changed/added in #12214 - do we prefer `prom-http` over
`prometheus-http` or is it more important that they align?)
- add `namespaceSelector:` per @francisco-mata (thanks! - sorry it took
so long to get this in)

   from issue:

> For some reason our target was not appearing on our prometheus
targets, we had to add a namespaceSelector key on the Service Monitor to
successfully appear

Co-authored-by: EdwardAngert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Area: coder.com/docs docs-ready Ready to be worked on for docs, details are clear
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: use consistent examples in prometheus doc and add namespaceSelector spec coder/coder
2 participants
@EdwardAngert @francisco-mata