Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: some deployments settings are hidden #15420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
defelmnq opened this issue Nov 7, 2024 · 0 comments · Fixed by #16798
Closed

fix: some deployments settings are hidden #15420

defelmnq opened this issue Nov 7, 2024 · 0 comments · Fixed by #16798
Assignees
Labels
bug risk Prone to bugs needs-triage Issue that require triage

Comments

@defelmnq
Copy link
Contributor

defelmnq commented Nov 7, 2024

Deployments admins should be able to access ${DEPLOYMENT_URL}/deployment/notifications?tab=settings page and see all the options related to notifications.

These options are fetched from the Options set here - with the group Notifications.

These options are then given to the OptionsTable component here.

The problem is then that the OptionsTable component is not displaying the elements with an empty value.

As the Webhook URL has no default value - users are not able to discover this option before setting it up to a value.

--

I've not investigated but can imagine the problem also happen with other options.

@coder-labeler coder-labeler bot added bug risk Prone to bugs needs-triage Issue that require triage labels Nov 7, 2024
@mtojek mtojek self-assigned this Mar 4, 2025
@mtojek mtojek closed this as completed in 975ea23 Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug risk Prone to bugs needs-triage Issue that require triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants