Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix Coder support links relative path #15542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MrPeacockNLB opened this issue Nov 16, 2024 · 0 comments · Fixed by #16572
Closed

fix Coder support links relative path #15542

MrPeacockNLB opened this issue Nov 16, 2024 · 0 comments · Fixed by #16572
Assignees
@mtojek
Labels
s3 Bugs that confuse, annoy, or are purely cosmetic

Comments

@MrPeacockNLB
Copy link
Contributor

description

I want to add a link to /icons to show the way how to find a served icon for an coder application.

  - name: CODER_SUPPORT_LINKS
    value: >
      [
        {"name": "Coder Wiki", "target": "https://wiki.local/Coder", "icon": "bug"},
        {"name": "Coder Icons", "target": "/icons", "icon": "bug"}
      ]

Problem

The relative path expands to user context.

https://coder.com/@SomeUser/icons

Solution

The path should be relative. E.g.

https://coder.com/icons
@coder-labeler coder-labeler bot added the bug risk Prone to bugs label Nov 16, 2024
@mtojek mtojek self-assigned this Feb 14, 2025
@mtojek mtojek mentioned this issue Feb 14, 2025
Merged
@matifali matifali added s3 Bugs that confuse, annoy, or are purely cosmetic and removed bug risk Prone to bugs labels Feb 14, 2025
@mtojek mtojek closed this as completed in 1c5a042 Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtojek mtojek

Labels
s3 Bugs that confuse, annoy, or are purely cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: include origin in support link coder/coder
3 participants
@matifali @mtojek @MrPeacockNLB