Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bug: creating a workspace build with workspace_tags variable fails with error: 'There is no variable named "var"' #15894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnstcn opened this issue Dec 17, 2024 · 0 comments · Fixed by #15897
Closed

bug: creating a workspace build with workspace_tags variable fails with error: 'There is no variable named "var"' #15894

johnstcn opened this issue Dec 17, 2024 · 0 comments · Fixed by #15897
Assignees
@johnstcn

Comments

@johnstcn
Copy link
Member

While working on #15800 I neglected to add the discovered variables into the correct format expected by wsbuilder. This causes workspace build creation to fail if using a template that has a Terraform variable for a tag value in the coder_workspace_tags data source.
@johnstcn johnstcn self-assigned this Dec 17, 2024
@coder-labeler coder-labeler bot added bug risk Prone to bugs needs-triage Issue that require triage labels Dec 17, 2024
@johnstcn johnstcn removed bug risk Prone to bugs needs-triage Issue that require triage labels Dec 17, 2024
@johnstcn johnstcn linked a pull request Dec 17, 2024 that will close this issue
fix(coderd/wsbuilder): correctly evaluate dynamic workspace tag values #15897
Merged
@johnstcn johnstcn mentioned this issue Dec 17, 2024
Merged
johnstcn added a commit that referenced this issue Dec 17, 2024
@johnstcn
fix(coderd/wsbuilder): correctly evaluate dynamic workspace tag values (
dcf5153 
#15897)

Relates to #15894:

- Adds `coderdenttest.NewExternalProvisionerDaemonTerraform`
- Adds integration-style test coverage for creating a workspace with
`coder_workspace_tags` specified in `main.tf`
- Modifies `coderd/wsbuilder` to fetch template version variables and
  includes them in eval context for evaluating `coder_workspace_tags`
johnstcn added a commit that referenced this issue Dec 18, 2024
@johnstcn
fix(coderd/wsbuilder): correctly evaluate dynamic workspace tag values (
01f1c94 
#15897)

Relates to #15894:

- Adds `coderdenttest.NewExternalProvisionerDaemonTerraform`
- Adds integration-style test coverage for creating a workspace with
`coder_workspace_tags` specified in `main.tf`
- Modifies `coderd/wsbuilder` to fetch template version variables and
  includes them in eval context for evaluating `coder_workspace_tags`

(cherry picked from commit dcf5153)
stirby pushed a commit that referenced this issue Jan 2, 2025
@johnstcn @stirby
fix(coderd/wsbuilder): correctly evaluate dynamic workspace tag values (
38f471a 
#15897)

Relates to #15894:

- Adds `coderdenttest.NewExternalProvisionerDaemonTerraform`
- Adds integration-style test coverage for creating a workspace with
`coder_workspace_tags` specified in `main.tf`
- Modifies `coderd/wsbuilder` to fetch template version variables and
  includes them in eval context for evaluating `coder_workspace_tags`

(cherry picked from commit dcf5153)
(cherry picked from commit 01f1c94)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(coderd/wsbuilder): correctly evaluate dynamic workspace tag values coder/coder
1 participant
@johnstcn