Thanks to visit codestin.com
Credit goes to github.com

Skip to content

flake: peer TestConn/Buffering #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnstcn opened this issue May 20, 2022 · 2 comments
Closed

flake: peer TestConn/Buffering #1644

johnstcn opened this issue May 20, 2022 · 2 comments
Assignees
@johnstcn
Labels
api Area: HTTP API
Milestone
Community MVP

Comments

@johnstcn
Copy link
Member 

GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/Users/cian/Library/Caches/go-build"
GOENV="/Users/cian/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/cian/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/cian/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/opt/homebrew/Cellar/go/1.18.2/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/opt/homebrew/Cellar/go/1.18.2/libexec/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.18.2"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/cian/src/cdr/coder/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/hy/fr1pxrgs0115684d4d7srrfw0000gn/T/go-build1048837325=/tmp/go-build -gno-record-gcc-switches -fno-common"

=== FAIL: peer TestConn/Buffering (0.97s)                                                                                                                                                                          
    t.go:56: 2022-05-20 21:10:15.357 [DEBUG]    (client)        <conn.go:485>   creating data channel   {"label": "ping", "opts": "\u0026{ID:2 Negotiated:true Protocol: Unordered:false OpenOnDisconnect:true}"}
    t.go:56: 2022-05-20 21:10:15.357 [DEBUG]    (client)        <conn.go:485>   creating data channel   {"label": "echo", "opts": "\u0026{ID:1 Negotiated:true Protocol: Unordered:false OpenOnDisconnect:true}"}  
    t.go:56: 2022-05-20 21:10:15.357 [DEBUG]    (client)        <conn.go:290>   negotiating                                                                                                                        
    t.go:56: 2022-05-20 21:10:15.358 [DEBUG]    (server)        <conn.go:485>   creating data channel   {"label": "ping", "opts": "\u0026{ID:1 Negotiated:true Protocol: Unordered:false OpenOnDisconnect:true}"}  
    t.go:56: 2022-05-20 21:10:15.358 [DEBUG]    (client)        <conn.go:186>   ice gathering state updated     {"state": "gathering"}                                                                                                                                                                                      
    t.go:56: 2022-05-20 21:10:15.358 [DEBUG]    (server)        <conn.go:485>   creating data channel   {"label": "echo", "opts": "\u0026{ID:2 Negotiated:true Protocol: Unordered:false OpenOnDisconnect:true}"}  
    t.go:56: 2022-05-20 21:10:15.359 [DEBUG]    (client)        <conn.go:485>   creating data channel   {"label": "hello", "opts": "\u0026{ID:0 Negotiated:false Protocol: Unordered:false OpenOnDisconnect:false}"}
    t.go:56: 2022-05-20 21:10:15.358 [DEBUG]    (client)        <conn.go:314>   sending offer   {"offer": {"type": "offer", "sdp": "v=0\r\no=- 4010291775693992519 1653081015 IN IP4 0.0.0.0\r\ns=-\r\nt=0 0\r\na=fingerprint:sha-256 6B:74:3A:68:8A:D1:BC:6A:0B:55:9A:11:27:DB:D7:61:FA:26:0E:01:A1:E5:DA:7B:65:4A:09:A3:98
:DD:D6:C9\r\na=extmap-allow-mixed\r\na=group:BUNDLE 0\r\nm=application 9 UDP/DTLS/SCTP webrtc-datachannel\r\nc=IN IP4 0.0.0.0\r\na=setup:actpass\r\na=mid:0\r\na=sendrecv\r\na=sctp-port:5000\r\na=ice-ufrag:ANtltbUuhAntVzPY\r\na=ice-pwd:FucpBVMqiLLJsOoIuhzQoBCErpRVOCWK\r\n"}}
    t.go:56: 2022-05-20 21:10:15.359 [DEBUG]    (client)        <conn.go:320>   sent offer                                                                                                                         
    t.go:56: 2022-05-20 21:10:15.359 [DEBUG]    (client)        <conn.go:324>   awaiting remote description...                                                                                                     
    t.go:56: 2022-05-20 21:10:15.359 [DEBUG]    (client)        <conn.go:258>   sending local candidate {"candidate": "candidate:422338508 1 udp 2130706431 1.2.3.4 5081 typ host"}                                
    t.go:56: 2022-05-20 21:10:15.359 [DEBUG]    (server)        <conn.go:290>   negotiating                                                                                                                        
    t.go:56: 2022-05-20 21:10:15.360 [DEBUG]    (server)        <conn.go:324>   awaiting remote description...                                                                                                     
    t.go:56: 2022-05-20 21:10:15.359 [DEBUG]    (client)        <conn.go:186>   ice gathering state updated     {"state": "complete"}    
    t.go:56: 2022-05-20 21:10:15.360 [DEBUG]    (server)        <conn.go:330>   setting remote description                                                                                                         
    t.go:56: 2022-05-20 21:10:15.358 [DEBUG]    (client)        <conn.go:240>   signaling state updated {"state": "have-local-offer"}                                                                              
    t.go:56: 2022-05-20 21:10:15.360 [DEBUG]    (server)        <conn.go:240>   signaling state updated {"state": "have-remote-offer"}                                   
    t.go:56: 2022-05-20 21:10:15.374 [DEBUG]    (server)        <conn.go:240>   signaling state updated {"state": "stable"}           
    t.go:56: 2022-05-20 21:10:15.373 [DEBUG]    (server)        <conn.go:186>   ice gathering state updated     {"state": "gathering"}                                             
    t.go:56: 2022-05-20 21:10:15.393 [DEBUG]    (server)        <conn.go:353>   sending answer  {"answer": {"type": "answer", "sdp": "v=0\r\no=- 7738227771774414469 1653081015 IN IP4 0.0.0.0\r\ns=-\r\nt=0 0\r\na=fingerprint:sha-256 7B:8C:57:DD:FB:4D:D6:8F:4D:75:AA:B8:38:3E:15:AD:0D:38:0E:F6:2C:AC:7D:6E:AE:C6:25:5D:
06:41:4F:76\r\na=extmap-allow-mixed\r\na=group:BUNDLE 0\r\nm=application 9 UDP/DTLS/SCTP webrtc-datachannel\r\nc=IN IP4 0.0.0.0\r\na=setup:active\r\na=mid:0\r\na=sendrecv\r\na=sctp-port:5000\r\na=ice-ufrag:RkfLiiUOYlPOajbE\r\na=ice-pwd:ycYgJgHDHYaTDossqOhqsFGTGkMpvAzF\r\n"}}
    t.go:56: 2022-05-20 21:10:15.395 [DEBUG]    (server)        <conn.go:359>   sent answer                                                                   
    t.go:56: 2022-05-20 21:10:15.397 [DEBUG]    (server)        <conn.go:376>   accepting candidate     {"candidate": "candidate:422338508 1 udp 2130706431 1.2.3.4 5081 typ host"}                                                                                                                                         
    t.go:56: 2022-05-20 21:10:15.394 [DEBUG]    (server)        <conn.go:258>   sending local candidate {"candidate": "candidate:608990844 1 udp 2130706431 1.2.3.5 5847 typ host"}                                                                                                                                         
    t.go:56: 2022-05-20 21:10:15.394 [DEBUG]    (server)        <conn.go:186>   ice gathering state updated     {"state": "complete"}                                                                                                                                                                                       
    t.go:56: 2022-05-20 21:10:15.398 [DEBUG]    (server)        <conn.go:167>   ice connection state updated    {"state": "checking"}                                                                                                                                                                                       
    t.go:56: 2022-05-20 21:10:15.397 [DEBUG]    (client)        <conn.go:330>   setting remote description                                                                                                                                                                                                                  
    t.go:56: 2022-05-20 21:10:15.410 [DEBUG]    (server)        <conn.go:167>   ice connection state updated    {"state": "connected"}                                                                                                                                                                                      
    t.go:56: 2022-05-20 21:10:15.408 [DEBUG]    (client)        <conn.go:240>   signaling state updated {"state": "stable"}
    t.go:56: 2022-05-20 21:10:15.408 [DEBUG]    (client)        <conn.go:167>   ice connection state updated    {"state": "checking"}                 
    t.go:56: 2022-05-20 21:10:15.508 [DEBUG]    (client)        <conn.go:167>   ice connection state updated    {"state": "connected"}                                                                                                                                                                                      
    t.go:56: 2022-05-20 21:10:15.410 [DEBUG]    (client)        <conn.go:248>   selected candidate pair changed {"local": {"foundation": "422338508", "priority": 2130706431, "address": "1.2.3.4", "protocol": 1, "port": 5081, "type": 1, "component": 1, "relatedAddress": "", "relatedPort": 0, "tcpType": ""}, "remote"
: {"foundation": "3674517152", "priority": 1862270975, "address": "1.2.3.5", "protocol": 1, "port": 5847, "type": 3, "component": 1, "relatedAddress": "", "relatedPort": 0, "tcpType": ""}}
    t.go:56: 2022-05-20 21:10:15.410 [DEBUG]    (server)        <conn.go:248>   selected candidate pair changed {"local": {"foundation": "608990844", "priority": 2130706431, "address": "1.2.3.5", "protocol": 1, "port": 5847, "type": 1, "component": 1, "relatedAddress": "", "relatedPort": 0, "tcpType": ""}, "remote"
: {"foundation": "422338508", "priority": 2130706431, "address": "1.2.3.4", "protocol": 1, "port": 5081, "type": 1, "component": 1, "relatedAddress": "", "relatedPort": 0, "tcpType": ""}}                         
    t.go:56: 2022-05-20 21:10:15.410 [DEBUG]    (server)        <conn.go:244>   dtls transport state updated    {"state": "connecting"}                                                                                                                                                                                     
    t.go:56: 2022-05-20 21:10:15.408 [DEBUG]    (client)        <conn.go:376>   accepting candidate     {"candidate": "candidate:608990844 1 udp 2130706431 1.2.3.5 5847 typ host"}                                                                                                                                         
    t.go:56: 2022-05-20 21:10:15.410 [DEBUG]    (client)        <conn.go:244>   dtls transport state updated    {"state": "connecting"}                                                                                                                                                                                     
    t.go:56: 2022-05-20 21:10:15.553 [DEBUG]    (client)        <conn.go:244>   dtls transport state updated    {"state": "connected"}                                                                                                                                                                                      
    t.go:56: 2022-05-20 21:10:15.553 [DEBUG]    (server)        <conn.go:244>   dtls transport state updated    {"state": "connected"}
    t.go:56: 2022-05-20 21:10:15.627 [DEBUG]    (server)        <conn.go:204>   rtc connection updated  {"state": "connected"}
    t.go:56: 2022-05-20 21:10:15.542 [DEBUG]    (client)        <conn.go:204>   rtc connection updated  {"state": "connecting"}                       
    t.go:56: 2022-05-20 21:10:15.652 [DEBUG]    (client)        <conn.go:204>   rtc connection updated  {"state": "connected"}                                                                                                                                                                                              
    t.go:56: 2022-05-20 21:10:15.680 [DEBUG]    (client)        <channel.go:127>        datachannel opening     {"id": 2, "label": "ping"}                                                                                                                                                                                  
    t.go:56: 2022-05-20 21:10:15.679 [DEBUG]    (server)        <channel.go:127>        datachannel opening     {"id": 1, "label": "ping"}                                                                                                                                                                                  
    t.go:56: 2022-05-20 21:10:15.679 [DEBUG]    (server)        <channel.go:127>        datachannel opening     {"id": 2, "label": "echo"}                                                                                                                                                                                  
    t.go:56: 2022-05-20 21:10:15.681 [DEBUG]    (client)        <channel.go:127>        datachannel opening     {"id": 1, "label": "echo"}
    t.go:56: 2022-05-20 21:10:15.681 [DEBUG]    (client)        <channel.go:127>        datachannel opening     {"id": 3, "label": "hello"}                                                                                                                                                                                 
    t.go:56: 2022-05-20 21:10:15.682 [DEBUG]    (server)        <channel.go:127>        datachannel opening     {"id": 3, "label": "hello"}                                                                                                                                                                                 
    t.go:56: 2022-05-20 21:10:16.121 [DEBUG]    (client)        <conn.go:167>   ice connection state updated    {"state": "disconnected"}                                                                                                                                                                                   
    t.go:56: 2022-05-20 21:10:16.122 [DEBUG]    (client)        <channel.go:284>        datachannel closing with error  {"id": 3, "label": "hello"} ...                                                                                                                                                                     
        "error": rtc disconnected. closing:                                                              
                     github.com/coder/coder/peer.(*Channel).init.func4
                         /Users/cian/src/cdr/coder/peer/channel.go:175                                                                                        
                   - connection was closed:                                                                                                                                                                        
                     github.com/coder/coder/peer.init                                                                                                                                                              
                         /Users/cian/src/cdr/coder/peer/conn.go:29                    
                   - EOF                                                                                                                                                                                           
    conn_test.go:153:                   
                Error Trace:    conn_test.go:153                                                         
                                                        asm_arm64.s:1263
                Error:          Received unexpected error:                                                                                                    
                                Stream closed                                                            
                Test:           TestConn/Buffering                                                       
    t.go:56: 2022-05-20 21:10:16.129 [DEBUG]    (server)        <conn.go:167>   ice connection state updated    {"state": "disconnected"}                                                                                                                                                                                   
    t.go:56: 2022-05-20 21:10:16.122 [DEBUG]    (client)        <conn.go:204>   rtc connection updated  {"state": "disconnected"}  
    t.go:56: 2022-05-20 21:10:16.165 [DEBUG]    (client)        <conn.go:167>   ice connection state updated    {"state": "connected"}
    t.go:56: 2022-05-20 21:10:16.177 [DEBUG]    (client)        <conn.go:204>   rtc connection updated  {"state": "connected"}
    t.go:56: 2022-05-20 21:10:16.165 [DEBUG]    (server)        <conn.go:167>   ice connection state updated    {"state": "connected"}
    t.go:56: 2022-05-20 21:10:16.166 [DEBUG]    (server)        <conn.go:204>   rtc connection updated  {"state": "disconnected"}                                                                                                                                                                                           
    t.go:56: 2022-05-20 21:10:16.205 [DEBUG]    (server)        <conn.go:204>   rtc connection updated  {"state": "connected"}                                                                                                                                                                                              
    t.go:56: 2022-05-20 21:10:16.167 [DEBUG]    (server)        <channel.go:284>        datachannel closing with error  {"id": 3, "label": "hello"} ...                                                                                                                                                                     
        "error": rtc disconnected. closing:
                     github.com/coder/coder/peer.(*Channel).init.func4                                                                                        
                         /Users/cian/src/cdr/coder/peer/channel.go:175                                                                                        
                   - connection was closed:                                                              
                     github.com/coder/coder/peer.init                                                                                                         
                         /Users/cian/src/cdr/coder/peer/conn.go:29                                                                                            
                   - EOF                                                       
    t.go:56: 2022-05-20 21:10:16.208 [DEBUG]    (client)        <conn.go:578>   closing conn with error {"error": null}                                                                                                                                                                                                     
    t.go:56: 2022-05-20 21:10:16.218 [DEBUG]    (client)        <channel.go:284>        datachannel closing with error  {"id": 2, "label": "ping"} ...                                                                                                                                                                      
        "error": connection was closed:                                        
                     github.com/coder/coder/peer.init                                                                                                         
                         /Users/cian/src/cdr/coder/peer/conn.go:29                                                                                            
                   - EOF                                                       
    t.go:56: 2022-05-20 21:10:16.257 [DEBUG]    (client)        <channel.go:284>        datachannel closing with error  {"id": 1, "label": "echo"} ...                                                                                                                                                                      
        "error": connection was closed:                                        
                     github.com/coder/coder/peer.init                                                                                                         
                         /Users/cian/src/cdr/coder/peer/conn.go:29                                                                                            
                   - EOF                                                       
    t.go:56: 2022-05-20 21:10:16.259 [DEBUG]    (client)        <conn.go:244>   dtls transport state updated    {"state": "closed"}                                                                                                                                                                                         
    t.go:56: 2022-05-20 21:10:16.272 [DEBUG]    (client)        <conn.go:596>   waiting for rtc connection close...                                                                                                                                                                                                         
    t.go:56: 2022-05-20 21:10:16.284 [DEBUG]    (server)        <channel.go:284>        datachannel closing with error  {"id": 2, "label": "echo"} ...                                                                                                                                                                      
        "error": connection was closed:                                        
                     github.com/coder/coder/peer.init                                                                                                         
                         /Users/cian/src/cdr/coder/peer/conn.go:29                                                                                            
                   - EOF                                                       
    t.go:56: 2022-05-20 21:10:16.285 [DEBUG]    (server)        <conn.go:578>   closing conn with error ...                                                                                                                                                                                                                 
        "error": read ping echo channel:                                       
                     github.com/coder/coder/peer.(*Conn).pingEchoChannel.func1.1                                                                              
                         /Users/cian/src/cdr/coder/peer/conn.go:439                                                                                           
                   - connection was closed:                                    
                     github.com/coder/coder/peer.init                                                                                                         
                         /Users/cian/src/cdr/coder/peer/conn.go:29                                                                                            
                   - EOF                                                       
    t.go:56: 2022-05-20 21:10:16.286 [DEBUG]    (client)        <conn.go:167>   ice connection state updated    {"state": "closed"}                                                                                                                                                                                         
    t.go:56: 2022-05-20 21:10:16.286 [DEBUG]    (client)        <conn.go:600>   waiting for ice connection close...                                                                                                                                                                                                         
    t.go:56: 2022-05-20 21:10:16.297 [DEBUG]    (client)        <conn.go:612>   closed                                                                        
    t.go:56: 2022-05-20 21:10:16.285 [DEBUG]    (server)        <channel.go:284>        datachannel closing with error  {"id": 1, "label": "ping"} ...                                                                                                                                                                      
        "error": read ping echo channel:                                       
                     github.com/coder/coder/peer.(*Conn).pingEchoChannel.func1.1                                                                              
                         /Users/cian/src/cdr/coder/peer/conn.go:439                                                                                           
                   - connection was closed:                                    
                     github.com/coder/coder/peer.init                                                                                                         
                         /Users/cian/src/cdr/coder/peer/conn.go:29                                                                                            
                   - EOF                                                       
    t.go:56: 2022-05-20 21:10:16.312 [DEBUG]    (server)        <conn.go:244>   dtls transport state updated    {"state": "closed"}                                                                                                                                                                                         
    t.go:56: 2022-05-20 21:10:16.313 [DEBUG]    (server)        <conn.go:596>   waiting for rtc connection close...                                                                                                                                                                                                         
    t.go:56: 2022-05-20 21:10:16.323 [DEBUG]    (server)        <conn.go:600>   waiting for ice connection close...                                                                                                                                                                                                         
    t.go:56: 2022-05-20 21:10:16.313 [DEBUG]    (server)        <conn.go:167>   ice connection state updated    {"state": "closed"}                                                                                                                                                                                         
    t.go:56: 2022-05-20 21:10:16.324 [DEBUG]    (server)        <conn.go:612>   closed                                                                        
    --- FAIL: TestConn/Buffering (0.97s)
@johnstcn
Copy link
Member Author

Potentially a duplicate of #1626

@misskniss misskniss added the api Area: HTTP API label May 24, 2022
kylecarbs added a commit that referenced this issue May 26, 2022
@kylecarbs
fix: Close peer negotiate mutex if we haven't negotiated
c7ae085 
Closes #1706 and #1644.
@kylecarbs kylecarbs mentioned this issue May 26, 2022
Merged
kylecarbs added a commit that referenced this issue May 27, 2022
@kylecarbs
fix: Close peer negotiate mutex if we haven't negotiated
a7a1ec5 
Closes #1706 and #1644.
kylecarbs added a commit that referenced this issue May 27, 2022
@kylecarbs
fix: Close peer negotiate mutex if we haven't negotiated (#1774)
984dc2b 
Closes #1706 and #1644.
@johnstcn
Copy link
Member Author

Closed by #1774

@misskniss misskniss added this to the Community MVP milestone Jun 3, 2022
kylecarbs added a commit that referenced this issue Jun 10, 2022
@kylecarbs
fix: Close peer negotiate mutex if we haven't negotiated (#1774)
7372c06 
Closes #1706 and #1644.
@mafredri mafredri mentioned this issue Jul 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnstcn johnstcn

Labels
api Area: HTTP API
Projects
None yet
Milestone
Community MVP
Development

No branches or pull requests
3 participants
@misskniss @johnstcn @coadler