Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bug: /deployment/overview page is broken when no experiments are set #17583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
BrunoQuaresma opened this issue Apr 28, 2025 · 0 comments · Fixed by #17584
Closed
1 task done

bug: /deployment/overview page is broken when no experiments are set #17583

BrunoQuaresma opened this issue Apr 28, 2025 · 0 comments · Fixed by #17584
Assignees
@BrunoQuaresma
Labels
site Area: frontend dashboard

Comments

@BrunoQuaresma
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

After running Coder in development mode using ./scripts/develop.sh, and navigating to /deployment/overview, an error is displayed. After some investigation from @dannykopping, he found the issue happens when there are no experiments set.

Relevant Log Output

Cannot read property of null (reading 'includes')

Expected Behavior

The page should be loaded without any errors.

Steps to Reproduce

  1. Run ./scripts/develop.sh without setting any experiments
  2. Navigate to /deployment/overview

Environment

Additional Context

The issue is new (previously worked fine)
@BrunoQuaresma BrunoQuaresma added the site Area: frontend dashboard label Apr 28, 2025
@BrunoQuaresma BrunoQuaresma self-assigned this Apr 28, 2025
@BrunoQuaresma BrunoQuaresma mentioned this issue Apr 28, 2025
Merged
BrunoQuaresma added a commit that referenced this issue Apr 28, 2025
@BrunoQuaresma
fix: handle null value for experiments (#17584)
5ca90ae 
Fix #17583

**Relevant info**
- `option.value` can be `null`
- It is always better to use `unknown` instead of `any`, and use type
assertion functions as `Array.isArray()` before using/accessing object
properties and functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrunoQuaresma BrunoQuaresma

Labels
site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle null value for experiments coder/coder
1 participant
@BrunoQuaresma