bug: session token is not being injected into app URIs #17704
Comments
|
Same issue with Cursor. Looks like the frontend is not populating the |
|
Just confirming, is it happening only when copying the link with the right click, correct? Does it work when clicking in the app button? I'm asking that because after taking a look into the code I see we only replace the session token during the click event and it has been like that for awhile. |
|
But this still a bug and I'm going to fix that asap. Probably I will have a PR for it tomorrow, is it ok? |
No it does not work when clicking too. Yes, tomorrow is fine. We have not released this yet. |
Fix #17704 During the [refactoring of WorkspaceApp response type](https://github.com/coder/coder/pull/17700/files#diff-a7e67944708c3c914a24a02d515a89ecd414bfe61890468dac08abde55ba8e96R112), I updated the logic to check if the session token should be injected causing external apps to not load correctly. To also avoid future confusions, we are only going to rely on the `app.external` prop to open apps externally instead of verifying if the URL does not use the HTTP protocol. I did some research and I didn't find out a use case where it would be a problem. I'm going to refactor this code very soon to allow opening apps from the workspaces page, so I will write the tests to cover this use case there. **Not included:** During my next refactoring I'm also going to change the code to support token injections directly in the HREF instead of making it happen during the click event.
Is there an existing issue for this?
Current Behavior
I think we have a regression somewhere related to parsing and injecting the coder session token into the URIs we link to in our coder app buttons on the dashboard.
Here's an example URI link:
Relevant Log Output
Expected Behavior
The linked URI contains a valid session token.
Steps to Reproduce
Environment
Additional Context
No response
The text was updated successfully, but these errors were encountered: