Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bug: When a workspace is on, the UI should derive time remaining from build deadline, not TTL #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #275
greyscaled opened this issue May 26, 2022 · 1 comment
Assignees
Labels
site Area: frontend dashboard
Milestone

Comments

@greyscaled
Copy link
Contributor

Overview

Right now, the UI derives time remaining for a running workspace from its ttl. This implies that if a user turns on a workspace that is scheduled to stop 8 hours later, then adjusts their ttl to 4 hours, the UI will present that the workspace will shutdown 4 hours later.

However, the underlying model uses a deadline on the build. The deadline may be stickier than ttl - for example, updating your ttl while your workspace is live may or may not cascade to your build.

Therefore it's best that the FE does the following:

  • for a running workspace, compute shutdown time from build deadline
  • for a non-running workspace, compute shutdown time from workspace ttl

Why It Matters

We want to accurately present when a workspace will shutdown, and not have a mismatch.

@greyscaled
Copy link
Contributor Author

Closed by #1920 (missed the automation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site Area: frontend dashboard
Projects
None yet
Development

No branches or pull requests

1 participant