fix!: use client ip when creating connection logs for workspace proxied app accesses #19788
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking API Change:
When running a scaletest, I noticed logs of the form:
to ensure logs are never omitted from the connection log due to a missing IP again (i.e. I'm not sure if we can always rely on a valid, parseable, IP from
(http.Request).RemoteAddr
), I've removed theNOT NULL
constraint onip
onconnection_logs
, and madeip
on the API response optional.The specific cause for these null IPs was the
/workspaceproxies/me/issue-signed-app-token [post]
endpoint constructing it's ownhttp.Request
without aRemoteAddr
set, and then passing that to the token issuer.To solve this, we'll have workspace proxies send the real IP of the client when calling
/workspaceproxies/me/issue-signed-app-token [post]
via the headerCoder-Workspace-Proxy-Real-IP
.