chore: add broker for test databases #19791
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
89fca3f to
ef3db0e
Compare
spikecurtis
commented
Sep 12, 2025
|
|
||
| func NewClient() (client *Client, err error) { | ||
| client = &Client{ | ||
| cmd: exec.Command("go", "run", "github.com/coder/coder/v2/cmd/dbtestbroker"), |
There was a problem hiding this comment.
This breaks if you are outside the directory tree of the repo, but I think that's pretty rare.
Still, in the PR above this on the stack I had to move some code around in templatepull_test.go
0758e24 to
a7e3c5d
Compare
a7e3c5d to
9191ef7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new test database broker, that runs in a subprocess, to clone test databases.
relates to coder/internal#927
Moving to a subprocess allows us to still clean up the test databases if the main test process dies (panics, times out, or is killed). We communicate with the subprocess over dRPC over yamux over stdio. When the main test process dies, the stdin pipe is closed, which triggers the broker to clean up any databases it cloned that were not explicitly discarded.