fix: trim whitespace from API tokens #19801
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes flake where subtests used t.Parallel() while sharing a DB from dbtestutil.NewDB(t). On Windows, the parent test’s t.Cleanup closed the DB before parallel subtests finished, yielding intermittent 401 Unauthorized instead of 200. Serializing the subtests keeps the DB alive for each case and removes the flake. Also trims whitespace from Authorization: Bearer and access_token token extraction for robustness; no change to precedence or overall behavior. Change-Id: Ifa9ad5bb297dc96612dbfb9ef8bb0e16d8ce5778 Signed-off-by: Thomas Kosiewski <[email protected]>
0f522e5 to
1188e6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trim whitespace from API tokens in Authorization headers and query parameters
This PR enhances the API token extraction logic by trimming whitespace from tokens obtained via:
The change ensures consistent token handling when tokens contain leading or trailing whitespace, improving authentication reliability.
The PR also removes unnecessary
t.Parallel()calls from OAuth2 bearer token tests to prevent potential race conditions during test execution.Fixes: coder/internal#967