-
Notifications
You must be signed in to change notification settings - Fork 881
TTL >24h has a confusing interaction with auto start #2318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@ammario Would we be OK with the following behaviour being possible:
Also, should a user be able to manually extend their "active lease" / deadline over a scheduled start time? |
I think the least surprising behavior if a workspace is on during at its scheduled autostart time that we extend its duration to the maximum of its current duration and the scheduled duration. Examples with a 9am start and 9 hour duration/6pm shutdown:
|
...unless this would violate template-level maximum, in which case we would extend up and until that maximum and no more. |
Even if it's before when the workspace would have stopped if it was freshly autostarted? I don't understand what the benefit of that is. I think we should put the caveat on the template-level maximum not the workspace schedule, if for no other reason than that we'll have 10x+ more people seeing the latter than the former, and they'll be generally less versed in the details and nuances. |
The interplay between auto start and auto off will never be obvious so we might as well avoid it. Here's what I propose: Limit out auto off to the smallest distance between auto on intervals (or never, if permitted by template). |
Actually even that is confusing when you reduce your auto start interval.... The 24h hard max is looking best to me. |
Yeah the problem with smallest distance is weekends leading to inconsistent behavior. The hard 24 hour thing is fine. It's not going to be sufficient for when we allow varying schedules, e.g. 9am-6pm on MWF and 10am-6pm on TTh. |
How would that schedule break it? Both of those ranges are 12h so they would be within the 24h max? |
Sorry those were meant as examples of variation not breaking examples of variation. |
This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity. |
As a user, if I set my template TTL to 27h and my auto-start to daily at 9am, my workspace schedule behavior looks like this:
I think we can all agree this is confusing.
Solution Ideas
The text was updated successfully, but these errors were encountered: