Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Frontend Workspace Lifecycle - Cancel Build #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
5 of 6 tasks
Tracked by #678
, #679
...
misskniss opened this issue Feb 9, 2022 · 2 comments · Fixed by #1735
Closed
5 of 6 tasks
Tracked by #678
, #679
...

Frontend Workspace Lifecycle - Cancel Build #233

misskniss opened this issue Feb 9, 2022 · 2 comments · Fixed by #1735
Assignees
@presleyp
Labels
site Area: frontend dashboard
Milestone
Community MVP

Comments

@misskniss
Copy link

misskniss commented Feb 9, 2022 •
edited by presleyp
Loading

  • show "Cancel action" button when workspaceStatus is starting, stopping, or deleting
  • show "Start workspace" and "Stop workspace" buttons when workspaceStatus is canceled or error
  • remove Retry button and related code (because we realized we need to allow the user to take any action from an unknown state such as canceled or failed)
  • remove loading version of start and stop buttons
  • hook up api to cancel builds
  • test that build is canceled

Note: There is an endpoint in the API specifically for canceling.

Given I have clicked "Stop workspace",
When I click "Cancel action",
Then I see the status "Canceling action" and no action buttons.
Moments later, I see the status "Canceled action" and "Start workspace" and "Stop workspace" buttons.

Given I have clicked "Start workspace",
When I click "Cancel action",
Then I see the status "Canceling action" and no action buttons.
Moments later, I see the status "Canceled action" and "Start workspace" and "Stop workspace" buttons.

The same should be true for deletion but the UI doesn't expose a delete button yet. You can test it from the CLI, though, with coder delete {workspaceName}.
@misskniss misskniss added this to the V2 Beta milestone Mar 31, 2022
@presleyp presleyp changed the title Cancel button(s) for workspace creation forms Frontend Workspace Management - Cancel Build Apr 1, 2022
@presleyp presleyp self-assigned this Apr 1, 2022
@presleyp presleyp added the site Area: frontend dashboard label Apr 1, 2022
@presleyp presleyp changed the title Frontend Workspace Management - Cancel Build Frontend Workspace Lifecycle - Cancel Build Apr 1, 2022
@misskniss misskniss mentioned this issue May 6, 2022
Closed
16 tasks
@misskniss
Copy link
Author

@kylecarbs @presleyp are we exposing the cancel option for community mvp?

@misskniss misskniss modified the milestones: V2 Beta, Community MVP May 16, 2022
@misskniss misskniss mentioned this issue May 16, 2022
Closed
16 tasks
@ammario
Copy link
Member

ammario commented May 23, 2022

@kylecarbs @presleyp are we exposing the cancel option for community mvp?

Very early on in v1 stuck, infinite builds rendered the product unusable. Imagine the frustration of being locked out of your development environment until the deployment administrator restarted coderd. I do think this is tablestakes enough for community.

@presleyp presleyp mentioned this issue May 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@presleyp presleyp

Labels
site Area: frontend dashboard
Projects
None yet
Milestone
Community MVP
Development

Successfully merging a pull request may close this issue.

feat: UI for canceling workspace builds coder/coder
3 participants
@presleyp @misskniss @ammario