Thanks to visit codestin.com
Credit goes to github.com

Skip to content

audit: Hide the auditor role in AGPL #2516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #4726
ntimo opened this issue Jun 20, 2022 · 12 comments
Closed
Tracked by #4726

audit: Hide the auditor role in AGPL #2516

ntimo opened this issue Jun 20, 2022 · 12 comments

Comments

@ntimo
Copy link
Contributor

ntimo commented Jun 20, 2022

Current situation

Currently the admin user does not have the aditor rule assigned. Which can be confusing.

Suggestion

Assign the default admin both the admin role and the auditor role

@kylecarbs
Copy link
Member

@Emyrk is the auditor role even used? Seems like we could just remove it.

@Emyrk
Copy link
Member

Emyrk commented Aug 24, 2022

@kylecarbs It was added because the UI actually added the "audit" page which can only be seen in developer mode. The page is hidden when the static files are compiled. So the auditor role is hooked up to the UI, but the backend feature is sparse atm (table exists, but that is it atm).

What I can do is just say the "user admin" has auditing permissions and delete the auditor role? I want to keep 1 role with that permission so that the FE team has a role they can use for testing that UI feature that is already implemented.

@BrunoQuaresma
Copy link
Collaborator

The owner role has audit permissions, but the admin does not. Is it something we want to add?

@kylecarbs kylecarbs changed the title Admin user does not have the audit role Hide the auditor role in AGPL Sep 23, 2022
@kylecarbs
Copy link
Member

@Emyrk I updated the title of this. I assume it's trivial to do... thoughts?

@bpmct bpmct changed the title Hide the auditor role in AGPL audit: Hide the auditor role in AGPL Oct 10, 2022
@Emyrk
Copy link
Member

Emyrk commented Oct 13, 2022

@kylecarbs the auditor role actually has a function now as we have audit logs.

What do we want to do? Hide the role if the licensed feature is not activated?

@kylecarbs
Copy link
Member

I think that would make sense

@Emyrk
Copy link
Member

Emyrk commented Oct 21, 2022

Interesting 🤔. Might want to mark some roles as "enterprise" or something. But show them if the user has the role, even if the license is not enterprise.

@Kira-Pilot Kira-Pilot mentioned this issue Oct 24, 2022
41 tasks
@github-actions
Copy link

This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Dec 21, 2022
@Emyrk
Copy link
Member

Emyrk commented Dec 21, 2022

Probably worth keeping this issue open.

The BE returns assignable roles here:

httpapi.Write(ctx, rw, http.StatusOK, assignableRoles(actorRoles.Roles, roles))

and for orgs:

httpapi.Write(ctx, rw, http.StatusOK, assignableRoles(actorRoles.Roles, roles))

We need to remove AGPL roles from this is they are not enabled in the license. But if a user has the role, and no longer has the license, that role should still appear on the user in question.

@github-actions github-actions bot removed the stale This issue is like stale bread. label Dec 22, 2022
@kylecarbs
Copy link
Member

kylecarbs commented Mar 14, 2023

@Emyrk should we close this out? It seems relatively low prio.

@Emyrk
Copy link
Member

Emyrk commented Mar 14, 2023

I would love to close this out until someone is very adamant they need this 😄.

This gets complicated in edge cases if someone downgrades from enterprise to APGL for example.

@Emyrk
Copy link
Member

Emyrk commented Mar 14, 2023

Closing unless requested again in the future.

@Emyrk Emyrk closed this as completed Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants