Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bug: edit schedule link and form render for others' workspaces #2655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ketang opened this issue Jun 26, 2022 · 2 comments · Fixed by #2698
Closed

Bug: edit schedule link and form render for others' workspaces #2655

ketang opened this issue Jun 26, 2022 · 2 comments · Fixed by #2698
Assignees
@AbhineetJain

Comments

@ketang
Copy link
Contributor

ketang commented Jun 26, 2022

I see the "Edit schedule" link on the workspace page and can view the form on someone else's workspace. However, I can't make changes; when I attempt to submit the form, I get an error. The link and form should be hidden if I can't use them.
@AbhineetJain AbhineetJain self-assigned this Jun 27, 2022
@AbhineetJain AbhineetJain mentioned this issue Jun 28, 2022
Merged
5 tasks
@AbhineetJain
Copy link
Contributor

@ketang Can you point me towards how I can reproduce the issue? I am unable to do it with the access controls provided by the standard Admin/Auditor/Member roles. Either cannot even read the workspace or can do both read and update.

@ketang
Copy link
Contributor Author

ketang commented Jun 29, 2022

I just tried it again, and it no longer behaves the same way. I see the same behavior as you, which is correct and expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbhineetJain AbhineetJain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: restrict edit schedule access coder/coder
2 participants
@ketang @AbhineetJain