Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix error messages in workspaceXService #3094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks
Tracked by #1943
presleyp opened this issue Jul 21, 2022 · 0 comments · Fixed by #3341
Closed
5 tasks
Tracked by #1943

Fix error messages in workspaceXService #3094

presleyp opened this issue Jul 21, 2022 · 0 comments · Fixed by #3341
Assignees
Labels
site Area: frontend dashboard

Comments

@presleyp
Copy link
Contributor

presleyp commented Jul 21, 2022

Problem

The frontend does not always display the error messages sent from the backend, and even when it does, it does not display the detail that is sometimes sent along with it.

Definition of done

  • There are no uses of displayError in this XService. To replace the error snackbar, render ErrorSummary in the relevant components with the dismissible prop. This way, the user can expand the error detail if desired without the snackbar disappearing too soon.
  • There are no uses of getFormHelpers in the components that consume errors from this XService. Switch to getFormHelpersWithError even if no error. (We will eventually rename it to replace the original getFormHelpers.)
  • The XService always assigns the API error, rather than a hard-coded error message. If a hard-coded error message is needed as a fallback, send it as a prop to ErrorSummary.
  • Errors are only unpacked/transformed in ErrorSummary and getFormHelpersWithError.
  • Storybook has a story for when the error(s) are showing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site Area: frontend dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants