-
Notifications
You must be signed in to change notification settings - Fork 881
Add HTTPS listen address flag #3123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What's the motivation for having both? It'd be nicer to have one, but if customers need both we'll obvs do it. |
Well, if we don't support having two listen addresses then coder won't be very useful unless it's behind a reverse proxy that can serve both HTTP and HTTPS or redirect from HTTP to HTTPS. And at that point, there's no point using coder's in built HTTPS support because you could just do it from your reverse proxy... |
After we add this flag I'd like to add a flag to redirect from HTTP to HTTPS, which means coder could be used entirely without a reverse proxy and behave sensibly. |
Is there a situation where a customer would want to serve Coder on both unencrypted HTTP and encrypted HTTPS? I think if the latter is present, they should always redirect HTTP to HTTPS. |
That makes sense @ketang but at the moment since coder can only listen on one or the other users are forced to do this with a reverse proxy, which makes the TLS options in coder useless since they'll be doing TLS termination at the reverse proxy. I don't mind changing this issue so if we listen on both we always do a HTTPS redirect from HTTP. |
Why can Coder only listen on one? |
Coder only listens on one right now since we only have one listen address flag. If you don't specify TLS certs then it's a HTTP server, otherwise it's a HTTPS server. |
I removed the |
This is something I would like to help with! From a user perspective, I would prefer only having to set one option and it should automatically redirect HTTP -> HTTPS for us. I don't know what implementation details look like but I think it could even be worth a breaking change for long-term UX improvements. I'd like to work on this but I think we need to align on direction and implementation. Would love to hear thoughts. |
This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity. |
Right now we have the
--address
flag which sets the listen address for Coder. I propose we add a new flag--https-address (CODER_HTTPS_ADDRESS)
and change the behavior of coderd to the following:If neither flag is set or ONLY
--address
is set, and TLS certs ARE NOT specified:--address
(or default)If neither flag is set or ONLY
--address
is set, and TLS certs are specified:--address
(or default)If
--https-address
is set and--address
is NOT:--https-address
If BOTH
--https-address
and--address
are set:--https-address
--address
I believe this be backwards compatible by keeping the same behavior around
--address
on it's own, while only introducing the new behavior when--https-address
is specified.The text was updated successfully, but these errors were encountered: