-
Notifications
You must be signed in to change notification settings - Fork 881
audit: audit the audit log π #4408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think it's easy enough to write go tests for this, it's probably best to have each feature/endpoint do it's own expected audit log testing. |
One thing that makes testing audit logs generated by AGPL routes hard is that the audit logs are generated in the enterprise code. You can really only assert the inputs to the enterprise code unless you want to move the tests there as well. |
Discussed with @coadler and the path forward here is to:
There is no way to automate audit log creation for new features, but I can write a quick how-to if that's helpful, @bpmct. |
That would be helpful! We can ensure that incoming features are in the audit log during QA and rely on automated tests to ensure records remain accurate. Does that make sense to you @Kira-Pilot? |
Yup, sounds good to me! @bpmct |
As we're quickly building/changing features, we need to ensure the audit log is capturing an accurate trail of user actions.
A π¦ has caught a couple of issues, but we need to do a comprehensive list of CRUD actions (CLI and dashboard) and ensure they're being accurately represented.
The intended behavior is documented here.
Additionally, we should have a process in place for ensuring incoming features (#4125, #4311) are represented in the audit log. Can we do this via automated tests or should we build something into the product/QA process?
It's better to start thinking about this now before we introduce a lot of debt.
The text was updated successfully, but these errors were encountered: