Thanks to visit codestin.com
Credit goes to github.com

Skip to content

audit: filtering can lead to confusing results because pagination state is kept #4518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #3907
, #4726
...
ammario opened this issue Oct 12, 2022 · 2 comments
Closed
Tracked by #3907
, #4726
...

audit: filtering can lead to confusing results because pagination state is kept #4518

ammario opened this issue Oct 12, 2022 · 2 comments
Assignees
@presleyp

Comments

@ammario
Copy link
Member

ammario commented Oct 12, 2022

If you're on page n>1 and then select a filter from the "Filters" drop down, you may see unexpected (or zero) results because the old pagination state is kept.

When there are zero results, there is no visual pager, so the user has no way of knowing what's going on short of opening up their HTTP inspector.

Screen Shot 2022-10-12 at 11 59 57 AM

Related: #3907
@ammario ammario added the bug label Oct 12, 2022
@bpmct bpmct mentioned this issue Oct 12, 2022
Closed
8 tasks
@f0ssel
Copy link
Contributor

f0ssel commented Oct 13, 2022

if the query changes we should probably kick back to page 1?

@Kira-Pilot Kira-Pilot mentioned this issue Oct 24, 2022
Closed
41 tasks
@presleyp
Copy link
Contributor

Fixed by #4753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@presleyp presleyp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@presleyp @ammario @f0ssel