-
Notifications
You must be signed in to change notification settings - Fork 887
Auto start workspace when I connect via SSH or visit an app #4973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We do this in our VS Code Extension now :) |
This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity. |
It will be very challenging to achieve this flow with The problem with OpenSSH is that it calls
|
@spikecurtis We already show provisioner/startup logs during SSH if the workspace is still starting, so I think it should work 🤔. Unless there's some scenarios in which it doesn't work. (The logs are indeed output to stderr for the ProxyCommand, and show up in the terminal.) The |
Do we necessarily always want to autostart? In v1 we had a command prompt ask if you wanted to start the workspace (only worked with It feels a bit strange to me to assume the user always wants the workspace auto started. |
I don't want to assume that this would be the case for every user, but we lean on our workspace suspension TTLs to clean up idle workspaces. The cost of starting a workspace is lower for us than additional friction for our users. Users will "fire" us if there is too much friction vs their pre-Coder workflows and habits. I'd suggest that we do the most intuitive thing by giving the user what they and/or their IDE has requested. The user doesn't care about the infrastructure (starting, stopping, etc), they just want to do their dev work. You could then add an option if there's enough user feedback to warrant the investment. |
@Emyrk I'm of the mind it should be a |
@mafredri if it is some sort of "opt in", then I think we can have the coder proxy command run the start, and delay the initial ssh. I do agree there is the problem of presenting feedback to the user that this is happening, but it sounds easier than the "prompt" problem. |
@Emyrk I'd lean towards opt-out, but essentially yes. Btw, we already delay the SSH command so everything should be in place except the autostart.
What's the problem, exactly? Yes, we can't prompt, but we can display output and already do. See the following recording: |
To give some feedbacks about our use cases, we're more interested in the auto-start when accessing an app. This would allow a friction-less experience to developers that use the online IDE. Also, this would make our review process a lot more easier. |
I primarily interact with my workspace via VS Code Remote SSH by clicking my workspace in the sidebar. However, it's often off.
I'm proposing the following behavior:
When I SSH into a stopped workspace (e.g.
ssh coder.ben-stable
), the workspace starts and streams the build log until it is finished. Then, the SSH connection starts. No need for the user to confirm. They clearly want to access their workspace.coder config-ssh --disable-auto-start
flag could disable this behavior. Doesn't seem necessary thoughWhen I visit a URL for an app on an agent (e.g.
https://dev.coder.com/@bpmct/ben-stable.dev/apps/code-server/?folder=/home/coder/coder
), the workspace starts and I can follow along with the build log. Once complete, and the app health check passes, I am redirected to the app. Related: Support starting the workspace when launching acoder_app
when it's off #2909To validate:
The text was updated successfully, but these errors were encountered: