Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Review issues and PRs for concerning content #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
misskniss opened this issue Mar 29, 2022 · 11 comments
Closed

Review issues and PRs for concerning content #650

misskniss opened this issue Mar 29, 2022 · 11 comments
Assignees
Labels
api Area: HTTP API
Milestone

Comments

@misskniss
Copy link

misskniss commented Mar 29, 2022

Description

Research if it's possible to close closed issues (delete them) so we start with a fresh state.

@ammario
Copy link
Member

ammario commented Mar 30, 2022

What exactly does this mean?

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 30, 2022

I think what Jen had in mind was deleting/removing closed issues when we open source the repo. I don't know if that's a possible or something I think we should do but she asked me to look into it.

@jsjoeio jsjoeio self-assigned this Mar 30, 2022
@misskniss misskniss added this to the V2 Beta milestone Apr 1, 2022
@jsjoeio jsjoeio changed the title Cull closed issues? Delete closed issues? Apr 4, 2022
@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 4, 2022

It appears that admins can permanently delete issues.

I am not sure if we want to do this since issues may contain historical information and there is no clear benefit to doing this. I think the only thing we want to do is make sure there is no sensitive information mentioned on GitHub but keeping issues should be fine.

I'll let @misskniss @kylecarbs weigh in before closing.

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 6, 2022

Waiting on response from others before moving forward on this.

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 6, 2022

Sounds like we don't want to delete closed issues but instead we want to check for any concerning content that shouldn't be public.

@jsjoeio jsjoeio changed the title Delete closed issues? Review issues and PRs for concerning content Apr 6, 2022
@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 6, 2022

@bpmct is going to look through PRs and post his list as well.

@bpmct
Copy link
Member

bpmct commented Apr 7, 2022

The following list of PRs either mention sensitive information or a Notion/Shortcut link:

(there are some mentions of coder/m or cdr/m not added here. they do not mention sensitive IP, just implementations we are porting over)

@tjcran
Copy link

tjcran commented Apr 7, 2022

I edited descriptions to remove notion links from descriptions. A few cases that reference a notion link in a comment, but I am not concerned with those.

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 7, 2022

@tjcran did you edit my list too? I still see some sensitive information.

Also, ICYMI we need to edit these and then delete the revisions (otherwise that information will be visible when we open source).

@misskniss
Copy link
Author

Thank you both for making the lists like this. We can review the lists in the grooming session today as well if there are remaining questions.
CC: @jsjoeio @bpmct

@misskniss misskniss added the api Area: HTTP API label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Area: HTTP API
Projects
None yet
Development

No branches or pull requests

5 participants