Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Workspaces can be created with invalid values, then cannot be deleted #831

Closed
@jsjoeio

Description

@jsjoeio

Description

If you create a new workspace with invalid values, there are a couple unexpected things:

  • you can't reuse that name (i.e. coder doesn't automatically delete the invalid workspace)
  • you can't delete the workspace
  • you can't edit the workspace to fix the invalid value

Steps to Reproduce

  1. `../coder workspaces create test-workspace``
  2. Select a project
  3. Enter invalid disk size (i.e. 3)
  4. See Error

Logs

Can't reuse workspace name

➜  aws-linux ../coder workspaces create joes-workspace
Select a project:                                         

> Creating with the  aws-linux  project...
Error: A workspace already exists named "joes-workspace"!

Can't delete workspace

➜  aws-linux ../coder workspaces delete joes-workspace
✔ Queued [51ms]
✔ Setting up [1ms]
⧗  Destroying workspace 
  Terraform 1.1.7
  Error: Invalid value for variable
  Disk size must be between 8 and 256.                       
                                                           
This was checked by the validation rule at main.tf:40,3-13.
✘ Destroying workspace [6114ms]
Error: recv workspace provision: read file "/var/folders/c7/ns6lqzvx3z10mq647y5g9lqc0000gn/T/provisionerd3690011094/terraform.tfstate": open /var/folders/c7/ns6lqzvx3z10mq647y5g9lqc0000gn/T/provisionerd3690011094/terraform.tfstate: no such file or directory

Can't edit workspace

➜  aws-linux ../coder workspaces edit joes-workspace
Usage:
  coder workspaces [command]

Aliases:
  workspaces, ws

Commands:
  create      Create a workspace from a project
  delete      
  list        
  show        
  ssh         
  start       
  stop        
  update      

Flags:
  -h, --help   help for workspaces

Global Flags:
      --global-config coder   Path to the global coder config directory (default "/Users/jp/Library/Application Support/coderv2")

Use "coder workspaces [command] --help" for more information about a command.
➜  aws-linux ../coder workspaces update joes-workspace
Workspace isn't outdated!

Metadata

Metadata

Assignees

Labels

apiArea: HTTP API

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions