Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add permissions for links and pages #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #670
presleyp opened this issue Apr 6, 2022 · 8 comments · Fixed by #1407
Closed
Tracked by #670

Add permissions for links and pages #884

presleyp opened this issue Apr 6, 2022 · 8 comments · Fixed by #1407
Assignees
Labels
api Area: HTTP API site Area: frontend dashboard
Milestone

Comments

@presleyp
Copy link
Contributor

presleyp commented Apr 6, 2022

I don't know if there's a ticket for this already in the RBAC epic, but I wanted to make sure we don't forget to guard the Admin menu, its links, and the pages it links to appropriately once we have RBAC in place.

I'm leaving details unfinished because I don't know if I should do this in my Users epic or an RBAC person should do it in their epic, and I know it's blocked but not by which exact ticket. @misskniss @vapurrmaid

@presleyp presleyp added this to the V2 Beta milestone Apr 6, 2022
@misskniss
Copy link

Thank you @presleyp . I dropped this in the RBAC epic for now.
CC: @Emyrk FYI

@Emyrk
Copy link
Member

Emyrk commented Apr 12, 2022

Thanks.
@presleyp and I talked about ways to handle this.

One solution

The backend could support an endpoint that allows users to query if they can do some action. This does not leak any information. The admin menu has: Users, Audit log, Metrics, .... The query could support a list of "resource" and "actions" for the UI to make informed decisions on.

Eg:
Should we show the "Settings" dropdown in "Admin"?
The query to the backend can have {"resource_type":"admin_settings", action:"read"}, which will return true for admins, but not for members. This would work to indicate which options to show:

{ // Total WIP structure. Just a very basic example
  "show_settings": {"resource_type":"admin_settings", action:"read"},
  "audit_logs": {"resource_type":"audit_log", action:"read"}
}

@misskniss
Copy link

Hey team! Please add your planning poker estimate with ZenHub @code-asher @presleyp @vapurrmaid

@misskniss misskniss added site Area: frontend dashboard api Area: HTTP API needs grooming 🪒 and removed needs grooming 🪒 labels Apr 26, 2022
@greyscaled
Copy link
Contributor

greyscaled commented Apr 28, 2022

Estimated at 13 because we are blocked on the design of permissions.

Can fill in more context later/synchronously. Will need to take a look at other tickets and match up the dependencies.

Once we understand the design of perms and the approach the FE will take, we will need to implement that.

Once we're here, this will become a 2, max 3, pointer.

But I don't want this to be lumped in with the broad architecture of permissions.

@ketang
Copy link
Contributor

ketang commented May 1, 2022

It's a little strange to me for this to be a 13 now but a 2 later. Shouldn't permissions design be separate?

@tjcran
Copy link

tjcran commented May 2, 2022

@Emyrk @vapurrmaid @presleyp do we need a synchronous conversation to sort this one out?

@Emyrk
Copy link
Member

Emyrk commented May 3, 2022

@tjcran yes

@BrunoQuaresma
Copy link
Collaborator

About this one, what pages should we verify? I can only see for now the user's page being affected. Am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Area: HTTP API site Area: frontend dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants