Thanks to visit codestin.com
Credit goes to github.com

Skip to content

provisioner_daemons table grows without bounds #9015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spikecurtis opened this issue Aug 10, 2023 · 2 comments · Fixed by #9108
Closed

provisioner_daemons table grows without bounds #9015

spikecurtis opened this issue Aug 10, 2023 · 2 comments · Fixed by #9108
Assignees
@spikecurtis
Labels
s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks

Comments

@spikecurtis
Copy link
Contributor

We only have SQL queries that add to the table and read from it --- so provisioner daemons are added but never removed.

Reading from the table is only used today to serve an API route to get all the daemons. It's not clear whether the front end ever uses this information, so it might be that the table has no defined purpose at present...
@spikecurtis spikecurtis added s3 Bugs that confuse, annoy, or are purely cosmetic bug labels Aug 10, 2023
@spikecurtis spikecurtis self-assigned this Aug 10, 2023
@spikecurtis spikecurtis mentioned this issue Aug 10, 2023
Merged
@spikecurtis
Copy link
Contributor Author

CLI and CoderSDK don't call the API endpoint, and as far as I can tell, the front end doesn't call it either.

It's not very useful for debugging either because the only distinguishing fields are created_at and tags --- even the names are randomly generated on the server side.

I think the best thing to do for now is just stop inserting into the table until we have an actual use case.

@spikecurtis spikecurtis mentioned this issue Aug 15, 2023
Merged
@matifali matifali added s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks and removed s3 Bugs that confuse, annoy, or are purely cosmetic labels Aug 24, 2023
@mtojek
Copy link
Member

mtojek commented Sep 8, 2023

I'm moving this back to the backlog/Ready column as we will postpone work around #5979.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spikecurtis spikecurtis

Labels
s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: stop inserting provisioner daemons into the database coder/coder
3 participants
@spikecurtis @matifali @mtojek