-
Notifications
You must be signed in to change notification settings - Fork 947
Closed
Labels
s4Internal bugs (e.g. test flakes), extreme edge cases, and bug risksInternal bugs (e.g. test flakes), extreme edge cases, and bug risks
Description
Push is supposed to be a superset of create, so we're carrying significant code debt. The slight mismatches in their functionality are mostly mistakes, e.g.:
- create locally validates the template name whereas push does not
- create accepts TTLs whereas push does not
We should make sure to deprecate create for a period of time, perhaps with an annoying time.Sleep
. We should also change push
to create a new template by default.
Bonus points for reducing duplication across template edit
too. See #9319 for an example bug.
Metadata
Metadata
Assignees
Labels
s4Internal bugs (e.g. test flakes), extreme edge cases, and bug risksInternal bugs (e.g. test flakes), extreme edge cases, and bug risks