From d5229e40770b3dcc25eca9a7a1ad5ce3327f9881 Mon Sep 17 00:00:00 2001 From: Mathias Fredriksson Date: Mon, 23 Oct 2023 14:20:32 +0000 Subject: [PATCH] test(agent): fix service banner trim test flake --- agent/agent_test.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/agent/agent_test.go b/agent/agent_test.go index bf71c4f1638f9..1d18c115000d3 100644 --- a/agent/agent_test.go +++ b/agent/agent_test.go @@ -350,8 +350,13 @@ func TestAgent_Session_TTY_MOTD(t *testing.T) { unexpected: []string{}, }, { - name: "Trim", - manifest: agentsdk.Manifest{}, + name: "Trim", + // Enable motd since it will be printed after the banner, + // this ensures that we can test for an exact mount of + // newlines. + manifest: agentsdk.Manifest{ + MOTDFile: name, + }, banner: codersdk.ServiceBannerConfig{ Enabled: true, Message: "\n\n\n\n\n\nbanner\n\n\n\n\n\n",