From 4a16b660c911a9e55e00dd1f2e7d9a3ede8cd1ca Mon Sep 17 00:00:00 2001
From: Garrett Delfosse <garrett@delfosse.dev>
Date: Wed, 29 Nov 2023 17:02:51 +0000
Subject: [PATCH 1/3] fix: do not allow selection of unsuccessful versions

---
 site/src/pages/WorkspacePage/ChangeVersionDialog.tsx | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/site/src/pages/WorkspacePage/ChangeVersionDialog.tsx b/site/src/pages/WorkspacePage/ChangeVersionDialog.tsx
index 801380a1cfd8d..65d9977746c4a 100644
--- a/site/src/pages/WorkspacePage/ChangeVersionDialog.tsx
+++ b/site/src/pages/WorkspacePage/ChangeVersionDialog.tsx
@@ -36,6 +36,9 @@ export const ChangeVersionDialog: FC<ChangeVersionDialogProps> = ({
   const [isAutocompleteOpen, setIsAutocompleteOpen] = useState(false);
   const selectedTemplateVersion = useRef<TemplateVersion | undefined>();
   const version = selectedTemplateVersion.current;
+  const validTemplateVersions = templateVersions?.filter((version) => {
+    return version.job.status == "succeeded"
+  })
 
   return (
     <ConfirmDialog
@@ -54,12 +57,12 @@ export const ChangeVersionDialog: FC<ChangeVersionDialogProps> = ({
       description={
         <Stack>
           <p>You are about to change the version of this workspace.</p>
-          {templateVersions ? (
+          {validTemplateVersions ? (
             <>
               <FormFields>
                 <Autocomplete
                   disableClearable
-                  options={templateVersions}
+                  options={validTemplateVersions}
                   defaultValue={defaultTemplateVersion}
                   id="template-version-autocomplete"
                   open={isAutocompleteOpen}

From 978fe0525f59a608dc8c4a0dd9896b8934a954ff Mon Sep 17 00:00:00 2001
From: Garrett Delfosse <garrett@delfosse.dev>
Date: Wed, 29 Nov 2023 17:05:38 +0000
Subject: [PATCH 2/3] make fmt

---
 site/src/pages/WorkspacePage/ChangeVersionDialog.tsx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/site/src/pages/WorkspacePage/ChangeVersionDialog.tsx b/site/src/pages/WorkspacePage/ChangeVersionDialog.tsx
index 65d9977746c4a..d94010aa16011 100644
--- a/site/src/pages/WorkspacePage/ChangeVersionDialog.tsx
+++ b/site/src/pages/WorkspacePage/ChangeVersionDialog.tsx
@@ -37,8 +37,8 @@ export const ChangeVersionDialog: FC<ChangeVersionDialogProps> = ({
   const selectedTemplateVersion = useRef<TemplateVersion | undefined>();
   const version = selectedTemplateVersion.current;
   const validTemplateVersions = templateVersions?.filter((version) => {
-    return version.job.status == "succeeded"
-  })
+    return version.job.status == "succeeded";
+  });
 
   return (
     <ConfirmDialog

From 0264c04e3c854bb6403050c41cad24d4af3ac9c3 Mon Sep 17 00:00:00 2001
From: Garrett Delfosse <garrett@delfosse.dev>
Date: Wed, 29 Nov 2023 17:20:57 +0000
Subject: [PATCH 3/3] lint

---
 site/src/pages/WorkspacePage/ChangeVersionDialog.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/site/src/pages/WorkspacePage/ChangeVersionDialog.tsx b/site/src/pages/WorkspacePage/ChangeVersionDialog.tsx
index d94010aa16011..ec8b2c45777b5 100644
--- a/site/src/pages/WorkspacePage/ChangeVersionDialog.tsx
+++ b/site/src/pages/WorkspacePage/ChangeVersionDialog.tsx
@@ -37,7 +37,7 @@ export const ChangeVersionDialog: FC<ChangeVersionDialogProps> = ({
   const selectedTemplateVersion = useRef<TemplateVersion | undefined>();
   const version = selectedTemplateVersion.current;
   const validTemplateVersions = templateVersions?.filter((version) => {
-    return version.job.status == "succeeded";
+    return version.job.status === "succeeded";
   });
 
   return (