From 7259ebbb8e17b47a695d7b4dab500a16ba37922f Mon Sep 17 00:00:00 2001 From: Steven Masley Date: Tue, 19 Mar 2024 10:09:56 -0500 Subject: [PATCH 1/2] chore: helm golden file test log output on failure Debugging this is hard without the actual helm error --- helm/provisioner/tests/chart_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/helm/provisioner/tests/chart_test.go b/helm/provisioner/tests/chart_test.go index 9bef79109f35e..f80cf4f542bf8 100644 --- a/helm/provisioner/tests/chart_test.go +++ b/helm/provisioner/tests/chart_test.go @@ -137,6 +137,9 @@ func TestUpdateGoldenFiles(t *testing.T) { valuesPath := tc.valuesFilePath() templateOutput, err := runHelmTemplate(t, helmPath, "..", valuesPath) + if err != nil { + t.Logf("Command output:\n%s", templateOutput) + } require.NoError(t, err, "failed to run `helm template -f %q`", valuesPath) goldenFilePath := tc.goldenFilePath() From c5f406c7c927cd621e2a5a88c2de8d8f69d0aadb Mon Sep 17 00:00:00 2001 From: Steven Masley Date: Tue, 19 Mar 2024 10:54:41 -0500 Subject: [PATCH 2/2] fmt --- helm/provisioner/tests/chart_test.go | 1 - 1 file changed, 1 deletion(-) diff --git a/helm/provisioner/tests/chart_test.go b/helm/provisioner/tests/chart_test.go index f80cf4f542bf8..78567b5b481d3 100644 --- a/helm/provisioner/tests/chart_test.go +++ b/helm/provisioner/tests/chart_test.go @@ -136,7 +136,6 @@ func TestUpdateGoldenFiles(t *testing.T) { valuesPath := tc.valuesFilePath() templateOutput, err := runHelmTemplate(t, helmPath, "..", valuesPath) - if err != nil { t.Logf("Command output:\n%s", templateOutput) }