feat: skip terraform destroy if there is no state when deleting #1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
May 19, 2022
provisioner/terraform/provision.go
Outdated
| @@ -190,6 +198,41 @@ func (t *terraform) Provision(stream proto.DRPCProvisioner_ProvisionStream) erro | |||
| } | |||
| }() | |||
|
|
|||
| // If we're destroying, exit early if there's no state. | |||
There was a problem hiding this comment.
It'd be helpful to elaborate here and explain the user-story of why we need this. It's an edge-case, and doesn't seem like suuuuper expected behavior.
AbhineetJain
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a workspace is being deleted and has no state (which could be caused by a failed create, maybe because the params didn't pass validation for example), then this skips calling
terraform apply -destroy.This alleviates some of the pain in #831 by allowing these broken workspaces to be deleted successfully. Future work will be done to mitigate broken workspaces in the first place.
Example with a workspace that is broken due to broken validation on params: