diff --git a/cli/update_test.go b/cli/update_test.go index 413c3d3c37f67..367a8196aa499 100644 --- a/cli/update_test.go +++ b/cli/update_test.go @@ -757,7 +757,7 @@ func TestUpdateValidateRichParameters(t *testing.T) { err := inv.Run() // TODO: improve validation so we catch this problem before it reaches the server // but for now just validate that the server actually catches invalid monotonicity - assert.ErrorContains(t, err, fmt.Sprintf("parameter value must be equal or greater than previous value: %s", tempVal)) + assert.ErrorContains(t, err, "parameter value '1' must be equal or greater than previous value: 2") }() matches := []string{ diff --git a/codersdk/richparameters.go b/codersdk/richparameters.go index e111527d9fb89..f00c947715f9d 100644 --- a/codersdk/richparameters.go +++ b/codersdk/richparameters.go @@ -78,7 +78,6 @@ func validateBuildParameter(richParameter TemplateVersionParameter, buildParamet if !matched { return xerrors.Errorf("parameter value must match one of options: %s", parameterValuesAsArray(richParameter.Options)) } - return nil } if !validationEnabled(richParameter) {