Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: add dynamic parameter warning if missing metadata #17809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 14, 2025
Merged

chore: add dynamic parameter warning if missing metadata #17809

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6f67a9a
chore: previous template versions missing dynamic param metadata
Emyrk May 13, 2025
2d1701d
chore: add parameter warning if metadata is missing
Emyrk May 13, 2025
0351ce5
update dbmem
Emyrk May 13, 2025
169bd5e
Merge remote-tracking branch 'origin/main' into stevenmasley/old_version
Emyrk May 14, 2025
9f947c3
refactor warnings into its own function
Emyrk May 14, 2025
a0f4d58
make the warning an error
Emyrk May 14, 2025
eb656ef
fmy
Emyrk May 14, 2025
478280b
Update coderd/parameters.go
Emyrk May 14, 2025
155f2cf
Pr suggestions
Emyrk May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Pr suggestions
  • Loading branch information
@Emyrk
Emyrk committed May 14, 2025
commit 155f2cffad8eb1f4b28a2e2658c44f7d71d4957e
10 changes: 5 additions & 5 deletions coderd/parameters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,24 +280,24 @@ func (api *API) getWorkspaceOwnerData(
// returns a warning diagnostic. Only versions 1.5+ return the module & plan data
// required.
func parameterProvisionerVersionDiagnostic(tf database.TemplateVersionTerraformValue) hcl.Diagnostics {
missingMetaData := hcl.Diagnostic{
missingMetadata := hcl.Diagnostic{
Severity: hcl.DiagError,
Summary: "This template version is missing required metadata to support dynamic parameters. Go back to the classic creation flow.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm. I don't like this. I would much prefer if we could have a way to expose this naturally to the frontend, forcing it over to the classic form. why make everyone click the "dynamic parameters suck" button? that's a super bad first impression

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, it is unfortunate. I want to get this in first, just to get an error up if someone toggles on dev and get this detection in. I will build on this experience.

We just need something now, otherwise it fails silently.

Detail: "To restore full functionality, please re-import the terraform as a new template version.",
}

if tf.ProvisionerdVersion == "" {
return hcl.Diagnostics{&missingMetaData}
return hcl.Diagnostics{&missingMetadata}
}

major, minor, err := apiversion.Parse(tf.ProvisionerdVersion)
if err != nil || tf.ProvisionerdVersion == "" {
return hcl.Diagnostics{&missingMetaData}
return hcl.Diagnostics{&missingMetadata}
} else if major < 1 || (major == 1 && minor < 5) {
missingMetaData.Detail = "This template version requires provisioner v1.5 or newer to support dynamic parameters. " +
missingMetadata.Detail = "This template version does not support dynamic parameters. " +
"Some options may be missing or incorrect. " +
"Please contact an administrator to update the provisioner and re-import the template version."
return hcl.Diagnostics{&missingMetaData}
return hcl.Diagnostics{&missingMetadata}
}

return nil
Expand Down
Loading