refactor: move required external auth buttons to the submit side #18586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
approved these changes
Jun 25, 2025
Member
code-asher
left a comment
There was a problem hiding this comment.
I think it would make sense to make the new component have parity with the previous one (or make the previous one reusable) but it looks good to me otherwise.
code-asher
approved these changes
Jun 26, 2025
| <Button size="sm" type="submit" disabled={isMissingExternalAuth}> | ||
| <Spinner | ||
| loading={createTaskMutation.isPending || isLoadingExternalAuth} | ||
| loading={createTaskMutation.isPending || isPollingExternalAuth} |
Member
There was a problem hiding this comment.
I think this one should be createTaskMutation.isPending || isLoadingExternalAuth || isPollingExternalAuth so it spins while waiting for auth to load as well right? (or we could use !missedExternalAuth).
| </Button> | ||
| </TooltipTrigger> | ||
| <TooltipContent> | ||
| Retry connect to {auth.display_name} |
Member
There was a problem hiding this comment.
I think ~ing sounds more natural: Retry connecting to
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
