From 1f1a10237f720d2303c8d6ec65a54cde33762ebe Mon Sep 17 00:00:00 2001
From: Thomas Kosiewski <tk@coder.com>
Date: Tue, 1 Sep 2026 11:54:08 +0000
Subject: [PATCH] fix(site/src): repair two stories broken by a11y-name drift

The biome 2.5.10 autofix added an aria-label to the premium trial form's
docs link, changing its accessible name out from under the Keyboard
Navigation story's exact-name query, and the license banner's collapse
trigger rendered its own button around Button (invalid HTML, two
identically named buttons in the accessibility tree). Use asChild on the
trigger and query the link by its aria-label.
---
 .../modules/dashboard/LicenseBanner/LicenseBannerView.tsx  | 7 +++++--
 .../PremiumPage/TrialRequestForm.stories.tsx               | 5 ++++-
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/site/src/modules/dashboard/LicenseBanner/LicenseBannerView.tsx b/site/src/modules/dashboard/LicenseBanner/LicenseBannerView.tsx
index 39404bca9e8..165b4efc1ec 100644
--- a/site/src/modules/dashboard/LicenseBanner/LicenseBannerView.tsx
+++ b/site/src/modules/dashboard/LicenseBanner/LicenseBannerView.tsx
@@ -143,9 +143,12 @@ const ExpandableLicenseMessageList: React.FC<{
 							<LicenseMessageList messages={hiddenMessages} />
 						</div>
 					</CollapsibleContent>
-					<CollapsibleTrigger className="text-xs mt-0.5">
+					{/* asChild: the trigger must not render its own <button>
+					    around Button, which is invalid HTML and exposes two
+					    identically named buttons to assistive tech. */}
+					<CollapsibleTrigger asChild>
 						<Button
-							className="text-content-primary px-0"
+							className="text-xs mt-0.5 text-content-primary px-0"
 							variant="subtle"
 							size="sm"
 						>
diff --git a/site/src/pages/DeploymentSettingsPage/PremiumPage/TrialRequestForm.stories.tsx b/site/src/pages/DeploymentSettingsPage/PremiumPage/TrialRequestForm.stories.tsx
index 1eaa92328a5..7fee06f7e0f 100644
--- a/site/src/pages/DeploymentSettingsPage/PremiumPage/TrialRequestForm.stories.tsx
+++ b/site/src/pages/DeploymentSettingsPage/PremiumPage/TrialRequestForm.stories.tsx
@@ -247,7 +247,10 @@ export const KeyboardNavigation: Story = {
 			canvas.getByRole("combobox", { name: /^Number of developers/ }),
 			canvas.getByRole("combobox", { name: /^Country/ }),
 			canvas.getByRole("checkbox"),
-			canvas.getByRole("link", { name: "Learn more" }),
+			// The link's accessible name is its aria-label, not its text.
+			canvas.getByRole("link", {
+				name: "Learn more about external PostgreSQL databases",
+			}),
 		];
 
 		for (const element of tabOrder) {